Skip to content

remove wrong function overload #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove wrong function overload #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions src/runtime/composables/useDrupalRoute/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,24 +46,6 @@ type UseDrupalRouteQueryInput =
| undefined
| null

// Overload signature to make the return type nullable when setting noError to
// true, because it allows the composable to return if no route entity is
// available.
export function useDrupalRoute<T extends object = object>(
queryInput: UseDrupalRouteQueryInput,
options: { noError: true },
providedRoute?: RouteLocationNormalizedLoaded,
): Promise<UseDrupalRoute<T | undefined>>

// Overload signature to make the return type non nullable without options or
// when the option noError is false, because the code ensures that the return
// type is always going to be the passed in generic type.
export function useDrupalRoute<T extends object = object>(
queryInput: UseDrupalRouteQueryInput,
options?: { noError?: false } | null,
providedRoute?: RouteLocationNormalizedLoaded,
): Promise<UseDrupalRoute<T>>

/**
* Composable that handles the Drupal routing for 404, redirects, metatags and
* entities.
Expand Down