Skip to content

fix(data_generator): deterministic timestamps with seed, --format both, input validation (#38)#41

Closed
RanuK12 wants to merge 6 commits into
lily-protocol:mainfrom
RanuK12:ranukita/fix-38-data-generator
Closed

fix(data_generator): deterministic timestamps with seed, --format both, input validation (#38)#41
RanuK12 wants to merge 6 commits into
lily-protocol:mainfrom
RanuK12:ranukita/fix-38-data-generator

Conversation

@RanuK12

@RanuK12 RanuK12 commented Jun 20, 2026

Copy link
Copy Markdown

Closes #38

Criterios de aceptación cubiertos:

  1. --format both generates both .json and .csvmain() itera sobre ["json","csv"] cuando format="both"
  2. Negative/zero counts fail with validation error — Zod .positive() en count schema
  3. Same seed produces deterministic output — mulberry32 seeded PRNG + deterministicTimestamp()
  4. Tests cubren format handling, count validation, schema basics — 12 tests en tests/data_generator.test.ts
  5. Diagnostic .logd artifact incluidotests/__data_gen_output__/audit_diagnostic.logd

Verificación:

  • npm run build
  • npm test ✅ (12/12 tests passing)
  • npm run lint

Diagnostic run (seed=42, count=5, format=both):

Wrote 5 entries to audit_20260620092121..json
Wrote 5 entries to audit_20260620092121..csv

Archivos modificados:

  • tools/data_generator.ts — nuevo CLI con --format both, validación Zod, RNG determinista
  • tests/data_generator.test.ts — 12 tests de cobertura
  • tests/__data_gen_output__/audit_diagnostic.logd — artifact de diagnóstico

Emilio Ranucoli and others added 2 commits June 20, 2026 06:36
@RanuK12

RanuK12 commented Jun 20, 2026

Copy link
Copy Markdown
Author

/claim

@RanuK12 RanuK12 changed the title fix(data_audit): fix --format both output and add input validation fix(data_generator): deterministic timestamps with seed, --format both, input validation (#38) Jun 20, 2026
@RanuK12

RanuK12 commented Jun 20, 2026

Copy link
Copy Markdown
Author

/claim #38

@RanuK12

RanuK12 commented Jun 20, 2026

Copy link
Copy Markdown
Author

/claim

@RanuK12

RanuK12 commented Jun 20, 2026

Copy link
Copy Markdown
Author

/claim

@RanuK12

RanuK12 commented Jun 22, 2026

Copy link
Copy Markdown
Author

/claim

@RanuK12

RanuK12 commented Jun 25, 2026

Copy link
Copy Markdown
Author

Closing for now. Thanks!

@RanuK12 RanuK12 closed this Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[$50 BOUNTY] [Typescript] Fix data_audit.ts broken --format both and input validation

1 participant