Fix guestagent service file

[songponssw]

Fix #3467

I think that the service file is supposed to be created with variables during the boot process.
I’ve fixed the heredoc to print LIMA_CIDATA_* in the boot script.

[jandubois]

I don't think interpolating the values in the script directly, and having to escape all normal '$' signsis maintenance-friendly. You could define the values first with an interpolated block, and then append the rest of the script verbatim:

cat >/etc/init.d/lima-guestagent <<EOF
#!/sbin/openrc-run
LIMA_CIDATA_GUEST_INSTALL_PREFIX=$LIMA_CIDATA_GUEST_INSTALL_PREFIX
...

EOF

cat >>/etc/init.d/lima-guestagent <<'EOF'
supervisor=supervise-daemon

log_file="${log_file:-/var/log/${RC_SVCNAME}.log}"
...
EOF

But then you can just as well write the values to /etc/conf.d/lima-guestagent.

[songponssw]

Got it!
Actually, the lima.env file contains the LIMA_CIDATA_*, so I just print it into conf.d/lima-guestagent.

[jandubois]

Got it! Actually, the lima.env file contains the LIMA_CIDATA_*, so I just print it into conf.d/lima-guestagent.

There is one problem with that though: lima.env uses the syntax of /etc/environment, but /etc/conf.d files are sourced as shell scripts.

So in lima.env you have LIMA_CIDATA_...=some random text" and everything until either a newline or the #` character will be part of the value.

In shell this can be a syntax error (or even run an unintended command), so the string needs to be quoted using the shell quoting rules.

Now, it looks like we don't have any crazy values in there, that can in turn contain quotes etc, so simply surrounding the value with double-quotes should be good enough.

The only value that I found creating problems was the user comment field (full name):

LIMA_CIDATA_COMMENT=Jan Dubois

And it is just noise, but I still think we should do this properly:

lima-alpine:~# rc-service lima-guestagent stop
/usr/libexec/rc/sh/openrc-run.sh: /etc/init.d/../conf.d/lima-guestagent: line 5: Dubois: not found
 * Stopping lima-guestagent ...                                                                                         [ ok ]
lima-alpine:~# rc-service lima-guestagent start
/usr/libexec/rc/sh/openrc-run.sh: /etc/init.d/../conf.d/lima-guestagent: line 5: Dubois: not found
 * Starting lima-guestagent ...                                                                                         [ ok ]

[songponssw]

Appreciate the clarification. I will make the changes.

[jandubois]

Thanks, LGTM