-
Notifications
You must be signed in to change notification settings - Fork 687
Add support for collecting instance IP address #3696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
songponssw
wants to merge
1
commit into
lima-vm:master
Choose a base branch
from
songponssw:guestagent-send-ip
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+516
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce812d0
to
7e5a9ee
Compare
AkihiroSuda
reviewed
Jul 6, 2025
AkihiroSuda
reviewed
Jul 6, 2025
AkihiroSuda
reviewed
Jul 6, 2025
AkihiroSuda
reviewed
Jul 6, 2025
AkihiroSuda
reviewed
Jul 6, 2025
jandubois
added a commit
to jandubois/alpine-lima
that referenced
this pull request
Jul 7, 2025
Added unconditionally to all editions because in the future Lima will depend on it (it is also part of the default Alpine cloud image). Ref lima-vm/lima#3696 Signed-off-by: Jan Dubois <[email protected]>
7e5a9ee
to
eb07981
Compare
Changes – Draft 2 (edited)gRPC
Hostagent
CLI
Note;
P.S. I'm trying my best to follow the design patterns found in the existing code. If there are any points that need refactoring, please let me know. |
3ba87dc
to
438de9f
Compare
c4ffa31
to
e84ea6a
Compare
Signed-off-by: Songpon Srisawai <[email protected]>
e84ea6a
to
1c9a442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
instance_info.json
file.Implementation details
With GuestAgent:
ip -j a
is embedded asjson_bytes
in the gRPC Events message.instance_info.json
file.Without GuestAgent (Plain mode):
executeSSH()
function signature to return both the command output and error (instead of just error).executeSSH()
to runip -j a
, processes the output, and writes the instance info locally.Testing
limactl start INSTNAME --network lima:user-v2