Minimize effects caused by restarting guestagent #4217
Conversation
norio-nomura
changed the title
norio-nomura
changed the title
| Short: "Install a systemd unit (user)", | ||
| RunE: installSystemdAction, | ||
| } | ||
| installSystemdCommand.Flags().Bool("guestagent-updated", false, "Indicate that the guest agent has been updated") |
There was a problem hiding this comment.
Alternatively you can just compare mtime of os.Executable to detect whether it was updated
There was a problem hiding this comment.
I wanted to use the judgment result of "update guestagent" made in the boot script.
I don't want to increase the judgment logic of the update.
|
|
||
| [Service] | ||
| ExecStart={{.Binary}} daemon {{.Args}} | ||
| ExecStart={{.Binary}} daemon {{.Args}} --runtime-dir="%t/%N" |
There was a problem hiding this comment.
"%t/%N" will be expanded to "/run/lima-guestagent" by systemd.
| Short: "Run the daemon", | ||
| RunE: daemonAction, | ||
| } | ||
| daemonCommand.Flags().String("runtime-dir", "/run/lima-guestagent", "Directory to store runtime state") |
There was a problem hiding this comment.
Why does this need to be customizable?
There was a problem hiding this comment.
for environment that does not want to use "/run/lima-guestagent"?
I don't know if there is such an environment. However, I can't think of a reason why it's better to hardcode this.
norio-nomura
force-pushed
the
minimize-affects-by-restarting-guestagent
branch
from
d621e82 to
683bf84
Compare
| @@ -1,4 +1,4 @@ | |||
| #!/bin/sh | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Does this work with Alpine?
There was a problem hiding this comment.
It works with both "template:alpine" and "template:alpine-iso", and has already been used in other boot scripts.
| return &ticker, nil | ||
| } | ||
|
|
||
| var _ Ticker = (*ebpfTicker)(nil) |
There was a problem hiding this comment.
Let Go check whether ebpfTicker fits the type Ticker interface.
By doing this, VSCode's Go extension recognizes the relationship between these types and makes it more convenient.
| t1, t2 Ticker | ||
| } | ||
|
|
||
| var _ Ticker = (*compoundTicker)(nil) |
… config have no changes. Signed-off-by: Norio Nomura <[email protected]>
…on stop/start `eventState` is saved at `/run/lima-guestagent/event-state.json`. The saved `eventState` is expected to be removed on OS restart. Signed-off-by: Norio Nomura <[email protected]>
norio-nomura
force-pushed
the
minimize-affects-by-restarting-guestagent
branch
from
683bf84 to
5008118
Compare
2 participants
lima-guestagent: Handle SIGTERM, support save/restoreeventStateon stop/startFixes #4216