-
Notifications
You must be signed in to change notification settings - Fork 21
feat: Allow specifying vmnet network UUID to disable DHCP #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c49d5b0 to
9de6fa5
Compare
|
let me know if you want to create a correspondent |
7dfe5f9 to
20d8ee1
Compare
…disable dhcp Adds the necessary build and service management files to integrate with my own fork of the socket_vmnet tool. This is while I wait for lima-vm/socket_vmnet#140 This includes: - A top-level Makefile for building and installing the socket_vmnet from the git submodule - A launchd plist for managing our own socket_vmnet service. - Updates to the socket path to be independent of Homebrew until the PR is merged
df1f00b to
f912515
Compare
|
@AkihiroSuda hey can you guys let me know what you think of this when you get a chance? :) |
|
Thanks, but please sign the commit for DCO (run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the comments, and sorry about the signature mishap.
I was using my corporate laptop and the setup there is a bit messy. Will fix.
I think my commits are all good yet but I dunno why DCO is failing now :(
|
c843af1 to
f7bdb95
Compare
|
my last commit has the sign-off but I dunno why DCO is failing... :( |
Yes, please |
f7bdb95 to
534d141
Compare
|
ok I fixed DCO, squashes all commits and made sure there is sign off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a breaking change
af97ba6 to
69b6d58
Compare
…ost network only) This commit introduces a new `--vmnet-network-uuid` command-line option to allow setting the `vmnet_network_identifier_key` for vmnet. This property is only applicable to a vmnet_interface in VMNET_HOST_MODE. If this property is set, the vmnet_interface is added to an isolated network with the specified identifier. No DHCP service is provided on this network. This is useful for certain applications where the users need an isolated network and are running their own dhcp to assign IPs in such network. See issue [lima-vm#139](lima-vm#139) Signed-off-by: Angelo (pallotron) Failla <[email protected]>
69b6d58 to
1d3ead9
Compare
| - [IP address is not assigned](#ip-address-is-not-assigned) | ||
| - [Links](#links) | ||
| - [Troubleshooting](#troubleshooting) | ||
| - [socket_vmnet: vmnet.framework support for rootless and VDE-less QEMU](#socket_vmnet-vmnetframework-support-for-rootless-and-vde-less-qemu) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
|
|
||
| > [!TIP] | ||
| > `sudo make install` is also available in addition to `sudo make install.bin`. | ||
| > [!TIP] > `sudo make install` is also available in addition to `sudo make install.bin`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
| - Create a host network where all VMs have static IPs. | ||
| - Run a custom DHCP server on one VM to assign IPs to others on the same network. | ||
|
|
||
| To disable the MacOS DHCP you must use `--vmnet-mode=host` and provide a `--vmnet-network-idenfitier` UUID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| To disable the MacOS DHCP you must use `--vmnet-mode=host` and provide a `--vmnet-network-idenfitier` UUID. | |
| To disable the macOS DHCP you must use `--vmnet-mode=host` and provide a `--vmnet-network-idenfitier` UUID. |
| "or \"\")\n" | ||
| " When vmnet mode is \"host\" and --vmnet-gateway is " | ||
| "not set, the internal DHCP will be disabled.\n" | ||
| " (default: \"random\")\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default should be an empty string
|
made a mess with |

What
This commit introduces a new
--vmnet-network-uuidcommand-line option to allow setting thevmnet_network_identifier_keyfor vmnet.This property is only applicable to a vmnet_interface in VMNET_HOST_MODE.
If this property is set, the vmnet_interface is added to an isolated network with the specified identifier.
No DHCP service is provided on this network.
Why
This is useful for certain applications where the users need an isolated network and are running their own dhcp to assign IPs in such network.
See issue #139
Testing
Printed new --help
Ran locally in host mode w/p network UUID provided -> DHCP enabled, backward compatible
Ran locally in shared mode -> DHCP enabled, backward compatible
Ran local in host mode + random network identifier: no dhcp, new behavior