Repository navigation
fix(load): wait out a busy instance before cleanup gives up - #5115
Merged
Merged
Conversation
After the ramp trashes a large directory, the Stack keeps the instance's lock for over a minute and answers 503 with Retry-After: every cleanup delete then failed at once, and the next step's setup with it. Reads and deletes now wait that out within their timeout (creates are never retried), runner cleanup deletes get the cleanup budget, and k6 teardown deletes up to four minutes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5107. On the VM capacity run, the ramp's cleanup and the next step's setup failed with 503 "the instance is busy, please retry later": after the ramp trashes its ~1,600 uploads, the Stack keeps the instance's lock for over a minute (
abort after too many failures without getting the lock), and answers 503 withRetry-After: 10.fixture-http.ts): GET, HEAD and DELETE wait that out within the request's own timeout; a create is never retried, as it may have committed.Checked with
make node-checks(651/651) and k6 against a fake busy server (503, 503, then 204).