Skip to content

feat(load): one step loop for capacity searches - #5123

Merged
shepilov merged 2 commits into
masterfrom
feat/load-step-loop
Oct 29, 2026
Merged

shepilov merged 2 commits into
masterfrom
feat/load-step-loop

Conversation

@shepilov

@shepilov shepilov commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Closes #5103. Follows #5122.

  • capacity/step-ramp.ts is the shared loop: it runs a level, judges it, then advances or stops. It stops at the first level that fails or cannot be judged, before a level beyond its budget, or when interrupted.
  • The shared-drive ramp now runs one k6 run per level through that loop, so it stops at its first failed level instead of loading every higher one. The levels share the run's ID in k6 metrics, so the dashboard panels are unchanged.
  • The mixed workload runs through the same loop.
  • The ramp and mixed runners check only the first level against the budgets. A later level beyond them, or one that would not finish within MAX_RUNTIME, ends the search as a lower bound, and budget_reached names the budget.
  • The fan-out and upload searches keep their own loops, which already stop at the first failure and give a lower bound at their budget. CONFIRMATION_ITERATIONS=0 skips the upload's bisection and confirmation and keeps its levels' bracket.
  • Tests cover advancing, stopping, budget exhaustion and interruption.

Test plan

  • make node-checks (664 tests, typecheck)
  • Load VM: local smoke campaign, outcome 0; each ramp level runs in its own k6 run under the run's ID
  • Load VM: ramp up to 64 stops at its first failing level: [16, 32), level 64 not run

Each level now starts on a clean drive, where before the earlier levels' uploads stayed in the drive. So the VM ramp moved from [8, 16) to [16, 32), and new ramp results aren't comparable with earlier ones.

@shepilov
shepilov requested a review from taratatach as a code owner October 28, 2026 17:25
@shepilov
shepilov removed the request for review from taratatach October 28, 2026 17:25
Base automatically changed from feat/load-step-ramp to master October 29, 2026 13:06
The shared-drive ramp and the mixed workload run each level in its own
k6 run through one step loop: the search stops at the first level that
does not pass, and a later level beyond a budget ends it as a lower
bound. CONFIRMATION_ITERATIONS=0 skips the upload search's refinement and
keeps the bracket its levels found.
@shepilov
shepilov force-pushed the feat/load-step-loop branch from ae3a828 to 931ad7e Compare October 29, 2026 13:08
@shepilov
shepilov merged commit 49eaa94 into master Oct 29, 2026
4 checks passed
@shepilov
shepilov deleted the feat/load-step-loop branch October 29, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(load): use one step-ramp workflow for capacity searches

1 participant