Repository navigation
refactor(load): define each dashboard panel once - #5125
Merged
Merged
Conversation
Tabs now reference shared panels instead of carrying copies, and the run, point and window controls keep the current tab, so one panel serves every tab. Workload no longer repeats Overview's run summary for the selected points. One status palette replaces the repeated value mappings, columns with the same settings share one override, and consecutive rows shown under the same condition share one grid. capacity-overview.json goes from 20,437 to 13,946 lines and from 140 to 103 panels, with the same views and queries otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5106.
capacity-overview.jsongoes from 20,437 to 13,946 lines and from 140 to 103 panels.dtabfrom their links, so they stay on the current tab, and their per-tab copies become one panel each.byRegexpoverride.Reviewed, kept as they are:
Tests:
make node-checkspasses, 663 tests. On a local Grafana 13.2, an upload, ramp, fan-out and mixed run each render the same on Overview and Infrastructure as before: same panel titles, values, status colours and positions. On Workload, only the summary panels are gone.