Repository navigation
fix(load): push k6 samples every second - #5127
Merged
Merged
Conversation
k6 pushed its metrics to Prometheus every 5 s, so a capacity attempt of a few seconds left one sample per counter and no request rate on the Workload tab. On the last DEV capacity run, the discoveries at 2, 4, 8 and 16 workers had a single sample each. One push per second gives them the two samples a rate needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
k6 pushed metrics to Prometheus every 5 s (the default), so a capacity attempt shorter than that left one sample per counter. The Workload tab's request rates were then empty for that point. On the last DEV capacity run, the discoveries at 2, 4, 8 and 16 workers had a single upload sample each, while confirmations had 13–44.
This sets
K6_PROMETHEUS_RW_PUSH_INTERVAL=1son the k6 service and updates the dashboard note.Smoke runs don't change: each smoke attempt uploads for under a second and k6 sends one final sample. Average upload rate by worker count on Overview remains the rate for those.
Tests:
make node-checkspasses, 663 tests. A local smoke passes, exit 0.