Repository navigation
fix(couchdb): create the doc when a concurrent request created its database - #5310
Closed
paultranvan wants to merge 1 commit into
Closed
paultranvan wants to merge 1 commit into
paultranvan wants to merge 1 commit into
Conversation
…tabase Upsert and CreateNamedDocWithDB create the database of a doctype on its first document. When two requests race on it, the one that loses gets file_exists from CreateDB and failed, while the database it needs is there. They now go on and create the document, as createDocOrDB does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
couchdb.UpsertandCreateNamedDocWithDBcreate the database of a doctype on its first document. When two requests race on it, the one that loses getsfile_existsfromCreateDBand returns it, while the database it needs exists. They now create the document anyway, ascreateDocOrDBalready does.POST /ai/index/statusarriving together for the firstio.cozy.ai.chat.ragdocs of an instance, one answered 500 and its status was lost.TestUpsertLosingDatabaseCreationRace, with a fake CouchDB that answersfile_existson the database creation.