Skip to content

TF-3455 Add applicative token login method #3527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 31 additions & 8 deletions lib/features/login/presentation/login_controller.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import 'package:model/account/password.dart';
import 'package:model/oidc/oidc_configuration.dart';
import 'package:model/oidc/request/oidc_request.dart';
import 'package:model/oidc/response/oidc_response.dart';
import 'package:model/oidc/token_id.dart';
import 'package:model/oidc/token_oidc.dart';
import 'package:tmail_ui_user/features/base/reloadable/reloadable_controller.dart';
import 'package:tmail_ui_user/features/home/domain/state/auto_sign_in_via_deep_link_state.dart';
Expand Down Expand Up @@ -96,6 +97,7 @@ class LoginController extends ReloadableController {
UserName? _username;
Password? _password;
Uri? _baseUri;
String _applicativeToken = '';

DeepLinksManager? _deepLinksManager;
StreamSubscription<DeepLinkData?>? _deepLinkDataStreamSubscription;
Expand Down Expand Up @@ -368,7 +370,7 @@ class LoginController extends ReloadableController {
consumeState(Stream.value(Left(AuthenticationUserFailure(CanNotFoundBaseUrl()))));
} else if (_username == null) {
consumeState(Stream.value(Left(AuthenticationUserFailure(CanNotFoundUserName()))));
} else if (_password == null) {
} else if (_password == null && _applicativeToken.isEmpty) {
consumeState(Stream.value(Left(AuthenticationUserFailure(CanNotFoundPassword()))));
} else {
if (PlatformInfo.isMobile && loginFormType.value == LoginFormType.credentialForm) {
Expand All @@ -378,13 +380,17 @@ class LoginController extends ReloadableController {
}
}

consumeState(
_authenticationInteractor.execute(
baseUrl: _currentBaseUrl!,
userName: _username!,
password: _password!
)
);
if (_password != null) {
consumeState(
_authenticationInteractor.execute(
baseUrl: _currentBaseUrl!,
userName: _username!,
password: _password!
)
);
} else {
_loginByApplicativeToken(_applicativeToken);
}
}
}

Expand Down Expand Up @@ -621,6 +627,23 @@ class LoginController extends ReloadableController {
loginFormType.value == LoginFormType.passwordForm ||
loginFormType.value == LoginFormType.credentialForm;

void onApplicativeTokenChange(String value) {
_applicativeToken = value;
}

void _loginByApplicativeToken(String token) {
_synchronizeTokenAndGetSession(
baseUri: _currentBaseUrl!,
tokenOIDC: TokenOIDC(_applicativeToken, TokenId(uuid.v4()), ''),
oidcConfiguration: OIDCConfiguration(
authority: '',
clientId: '',
scopes: [],
),
);
getSessionAction();
}

@override
void onClose() {
passFocusNode.dispose();
Expand Down
32 changes: 28 additions & 4 deletions lib/features/login/presentation/login_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@ import 'package:core/presentation/state/success.dart';
import 'package:core/presentation/utils/theme_utils.dart';
import 'package:core/presentation/views/text/type_ahead_form_field_builder.dart';
import 'package:flutter/material.dart';
import 'package:flutter_keyboard_visibility/flutter_keyboard_visibility.dart';
import 'package:get/get.dart';
import 'package:tmail_ui_user/features/base/widget/application_version_widget.dart';
import 'package:tmail_ui_user/features/base/widget/recent_item_tile_widget.dart';
import 'package:tmail_ui_user/features/login/domain/model/recent_login_url.dart';
import 'package:tmail_ui_user/features/login/presentation/base_login_view.dart';
import 'package:tmail_ui_user/features/login/presentation/login_form_type.dart';
import 'package:tmail_ui_user/features/login/presentation/privacy_link_widget.dart';
import 'package:tmail_ui_user/features/login/presentation/widgets/applicative_token_field.dart';
import 'package:tmail_ui_user/features/login/presentation/widgets/dns_lookup_input_form.dart';
import 'package:tmail_ui_user/features/login/presentation/widgets/horizontal_progress_loading_button.dart';
import 'package:tmail_ui_user/features/login/presentation/widgets/login_back_button.dart';
Expand Down Expand Up @@ -122,12 +124,34 @@ class LoginView extends BaseLoginView {
return const SizedBox.shrink();
}
}),
Obx(() {
switch (controller.loginFormType.value) {
case LoginFormType.passwordForm:
return ApplicativeTokenField(
onChanged: controller.onApplicativeTokenChange,
appLocalizations: AppLocalizations.of(context),
imagePath: controller.imagePaths,
);
default:
return const SizedBox.shrink();
}
}),
_buildLoadingProgress(context),
const Padding(
padding: EdgeInsets.only(top: 16),
child: PrivacyLinkWidget(),
KeyboardVisibilityBuilder(
builder: (context, visible) {
if (visible) return const SizedBox.shrink();

return const Column(
children: [
Padding(
padding: EdgeInsets.only(top: 16),
child: PrivacyLinkWidget(),
),
ApplicationVersionWidget(),
],
);
},
),
const ApplicationVersionWidget(),
]
),
)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
import 'package:core/presentation/resources/image_paths.dart';
import 'package:core/presentation/views/text/text_field_builder.dart';
import 'package:flutter/material.dart';
import 'package:flutter_svg/flutter_svg.dart';
import 'package:tmail_ui_user/features/base/widget/text_input_decoration_builder.dart';
import 'package:tmail_ui_user/main/localizations/app_localizations.dart';

class ApplicativeTokenField extends StatefulWidget {
final ValueChanged<String> onChanged;
final AppLocalizations appLocalizations;
final ImagePaths? imagePath;

const ApplicativeTokenField({
Key? key,
required this.onChanged,
required this.appLocalizations,
this.imagePath,
}) : super(key: key);

@override
State<ApplicativeTokenField> createState() => _ApplicativeTokenFieldState();
}

class _ApplicativeTokenFieldState extends State<ApplicativeTokenField> with SingleTickerProviderStateMixin {
final controller = TextEditingController();
final focusNode = FocusNode();
late final AnimationController rotationController;

@override
void initState() {
super.initState();
rotationController = AnimationController(
duration: const Duration(milliseconds: 200),
vsync: this,
);
}

@override
void dispose() {
controller.dispose();
focusNode.dispose();
rotationController.dispose();
super.dispose();
}

@override
Widget build(BuildContext context) {
return ExpansionTile(
title: Text(widget.appLocalizations.advancedSettings),
controlAffinity: ListTileControlAffinity.leading,
leading: widget.imagePath == null
? null
: RotationTransition(
turns: Tween(begin: 0.0, end: 0.5).animate(rotationController),
child: SvgPicture.asset(
widget.imagePath!.icArrowDown,
width: 24,
height: 24,
fit: BoxFit.fill,
),
),
shape: const Border(),
tilePadding: const EdgeInsets.symmetric(horizontal: 32),
childrenPadding: const EdgeInsets.symmetric(horizontal: 32),
onExpansionChanged: (isExpanded) {
if (isExpanded) {
rotationController.forward();
} else {
rotationController.reverse();
}
},
children: [
Row(
children: [
Text(
widget.appLocalizations.applicativeToken,
style: const TextStyle(fontWeight: FontWeight.bold, fontSize: 16),
),
const SizedBox(width: 8),
Expanded(
child: TextFieldBuilder(
controller: controller,
focusNode: focusNode,
autoFocus: true,
onTextChange: widget.onChanged,
maxLines: 1,
decoration: TextInputDecorationBuilder().build(),
),
),
],
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful if the text is too long (multiple language) the token input field will be too small.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expanded added

Text(widget.appLocalizations.someJMAPServicesDoNotSupportLoginViaPassword),
],
);
}
}
21 changes: 21 additions & 0 deletions lib/main/localizations/app_localizations.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4472,6 +4472,27 @@ class AppLocalizations {
);
}

String get advancedSettings {
return Intl.message(
'Advanced settings',
name: 'advancedSettings',
);
}

String get applicativeToken {
return Intl.message(
'Applicative token',
name: 'applicativeToken',
);
}

String get someJMAPServicesDoNotSupportLoginViaPassword {
return Intl.message(
'Some JMAP services do not support login via password for third party apps but instead allow generate applicative tokens.',
name: 'someJMAPServicesDoNotSupportLoginViaPassword',
);
}

String get downloadAttachmentInEMLPreviewWarningMessage {
return Intl.message(
'Downloading attachment. You can only download one file at a time.',
Expand Down
Loading