-
Notifications
You must be signed in to change notification settings - Fork 86
TF-3358 Save draft locally periodically #3598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
TF-3358 Save draft locally periodically #3598
Conversation
This PR has been deployed to https://linagora.github.io/tmail-flutter/3598. |
..._dashboard/presentation/widgets/local_email_draft/local_email_draft_list_dialog_builder.dart
Show resolved
Hide resolved
@@ -1,15 +1,15 @@ | |||
import 'package:core/presentation/state/failure.dart'; | |||
import 'package:core/presentation/state/success.dart'; | |||
|
|||
class RemoveComposerCacheSuccess extends UIState { | |||
class RemoveLocalEmailDraftSuccess extends UIState { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont need to have id
to see what local draft was removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is updated right on the UI so we don't need it.
import 'package:tmail_ui_user/features/caching/utils/caching_constants.dart'; | ||
import 'package:tmail_ui_user/features/mailbox_dashboard/data/model/local_email_draft.dart'; | ||
|
||
class LocalEmailDraftClient extends HiveCacheClient<LocalEmailDraft> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please dont forget to upgrade hiveDBVersion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a new box to the hive database does not require a version upgrade. A version upgrade is only required when changing the data structure of an existing box.
import 'package:core/presentation/state/failure.dart'; | ||
import 'package:core/presentation/state/success.dart'; | ||
|
||
class SaveLocalEmailDraftSuccess extends UIState {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, we should keep the id of which local email was saved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use it for anything right now, so keeping it at this point is unnecessary.
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
… successfully Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
cc29684
to
1582106
Compare
Issue
#3358
Resolved
Screen.Recording.2025-03-26.at.09.02.02.mov
Screen.Recording.2025-03-26.at.09.16.31.mov