Skip to content

Conversation

vim-zz
Copy link

@vim-zz vim-zz commented Jul 24, 2025

✨ PR Description

Purpose: Fix indentation error in Socket's _clear_io_state method to properly remove reader from event loop selector.
Main changes:

  • Fixed indentation of self._get_selector(loop).remove_reader(self._fd) line that was accidentally removed

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

Copy link

gitstream-cm bot commented Jul 24, 2025

Please mark which AI tools you used for this PR by checking the appropriate boxes:

  • GitHub Copilot
  • Cursor
  • ChatGPT
  • Tabnine
  • JetBrains AI Assistant
  • VSCode IntelliCode
  • Claude
  • Gemini
  • Other AI tool
  • No AI tools were used

Tip: If you want to avoid this comment in the future, you can add a label of the format 🤖 ai-* when creating your PR.

Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

The PR introduces a critical indentation issue that will cause Python syntax errors due to mixing tabs and spaces.

1 issues detected:

🐞 Bug - Mixed tab and space indentation will cause Python syntax errors at runtime.

Details: The indentation on line 161 uses tabs instead of spaces, which will cause a Python IndentationError or TabError when the code is executed. Python requires consistent indentation throughout a file.
File: zmq/asyncio.py (161-161)

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

loop = self._current_loop
if loop and not loop.is_closed() and self._fd != -1:
self._get_selector(loop).remove_reader(self._fd)
self._get_selector(loop).remove_reader(self._fd)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐞 Bug - Indentation Error: Replace the tab characters with the appropriate number of spaces (typically 4 or 8 spaces) to match the existing indentation style in the file.

Suggested change
self._get_selector(loop).remove_reader(self._fd)
self._get_selector(loop).remove_reader(self._fd)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant