Repository navigation
Allow the first argument of #[simd] functions to be f32x4<S> and such - #383
Conversation
…en-carrying, not just a literal _: Simd
|
I know it would be quite the huge change, but the naming feels inconsistent throughout between Simd vs token vs witness. Is there a distinction I'm missing, or could we call them all the same thing? (Simd, ExtractSimd::simd) |
|
I think I'm open to |
Or maybe SimdToken, based on this pr. I still think vector.simd() better matches, especially with vector.simd already existing. vector.token() is less obvious to me (but better than vector.witness()) |
|
Renamed. Any concerns other than naming? |
Dr-Emann
left a comment
There was a problem hiding this comment.
I still say .simd() would be better
|
Either way, definitely a breaking change to note for 1.0 |
|
This PR adds a mention to the changelog: https://github.com/linebender/fearless_simd/pull/383/changes#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed |
|
Saw the added section, missed the changed section somehow, awesome! |
Allow the first argument in
#[simd]functions to be anything simd-token-carrying, not just a literal_: SimdHeavily based on the ideas @RunDevelopment outlined in #379
Closes #379
I want to get it in before v1.0 because this is a small semver-breaking change (method moved from one trait to another)
@RunDevelopment please take a look