Reset contributed in BreakerState::reset_line - #854
Merged
nicoburns merged 2 commits intoSep 29, 2026
Merged
Conversation
DJMcNab
reviewed
Sep 28, 2026
DJMcNab
left a comment
DJMcNab
left a comment
Member
There was a problem hiding this comment.
Reset applying the strut also doesn't read great here.
That is, I think reset_line should be the caller of add_strut (although I'm also not entirely convinced by add_strut; it seems like the strut should arise naturally from adding a box from a style - especially if lines with only inline boxes don't want the struts anyway...)
DJMcNab
approved these changes
Sep 29, 2026
staging-devin-ai-integration
Bot
force-pushed
the
devin/1790619679-reset-line-buffers
branch
from
September 29, 2026 12:58
e614d8f to
1c869cb
Compare
Collaborator
Author
FWIW, I believe that lines with only inline boxes do want the strut |
Member
Hmm, I thought this was the logic about lines with absolutely no glyphs. I guess I'm still confused about that change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Contributions: Generated with Opus 5.5 High. Reviewed by me.
This is a small refactor motivated by code quality. Previously an
&mutreference tocontributedwas being passed intoLineBoxMetrics'sresetmethod. This is a violation of separation of concerns. Resetting contributed now happens in thereset_linemethod ofBreakerStatewhich actually ownscontributed.Changelog: None (pure refactor)