Add author name in blog post

[Arnab-Developer]

I have added author name in the blog post.

Related to #253

[Arnab-Developer]

@linkdotnet please review this PR.

[linkdotnet]

I will checkout your branch and play with it later to get some better grasp on your ideas.

[linkdotnet]

I am still confident that we don't need any custom dialog or HttpContext in the first place to make that feature work.

Here I set the name on my IDP (Auth0):

Which then I got via the claim and displayed in the blog:

For that we don't need much things:

1. We have to tell OIDC that we want profile information: options.Scope.Add("profile");
2. I wrote a small service that gets the user's name:

public async ValueTask<string?> GetDisplayNameAsync()
{
    var user = (await authenticationStateProvider.GetAuthenticationStateAsync()).User;
    if (user?.Identity is not { IsAuthenticated: true })
    {
        return null;
    }

    // Check a few (not sure what order is the best and if covers all but worked when I spiked something together)
    var name = user.FindFirst("name")?.Value
               ?? user.FindFirst("preferred_username")?.Value
               ?? user.FindFirst("nickname")?.Value;

    return string.IsNullOrWhiteSpace(name) ? null : name;
}

The advantage here is that we don't need HttpContext at all and we solely rely on how Blazor handles things aka AuthenticationStateProvider. This service than can be used in all sorts of places - that needs a bit design.

In the screenshot you are seeing, I really just did this:

@inject ICurrentUserService CurrentUser

...

@code {
    protected override async Task OnInitializedAsync()
    {
        AuthStateProvider.AuthenticationStateChanged += OnAuthStateChanged;
        displayName = await CurrentUser.GetDisplayNameAsync();
    }

Of course we need to check for authentication changes and so on, but that is "fine-tuning".

Let me know your thoughts about this one. I am absolutely open to discuss any direction, I would just like that it is "the standard of doing things" so also in a year folks understand the code and why it is there.

[linkdotnet]

Just from a style point of view: The other tests are using directly the Repository object rather than the DbContext.

[Arnab-Developer]

This is a test to validate if the AuthorName is not saved in the db, then at the time of loading with GetByIdAsync() of the Repository it should come as null.

First it adds a BlogPost entity in the db which don't have AuthorName in it with the DbContext. Then it pulls the data with GetByIdAsync() of the Repository and validate the AuthorName is null or not.

This same pattern has been followed in the ShouldLoadBlogPost test as well.

[Arnab-Developer]

@linkdotnet thanks for the detail explanation. I have understood your approach now. I have made the code changes as per your suggestion.

[linkdotnet]

Really good work - we are almost there!

[linkdotnet]

Where is the Test Author coming from?

[Arnab-Developer]

I have done the setup in the constructor.

[linkdotnet]

Good job on this one - looking good

[Arnab-Developer]

If you update the appsettings.json with proper idp info in your local and then run the app, is the AuthorName is coming properly?

"Authentication": {
	"Provider": "Auth0",
	"Domain": "",
	"ClientId": "",
	"ClientSecret": ""
},

Also you need to update the Program.cs like below.

- if (builder.Environment.IsDevelopment())
- {
-     builder.Services.UseDummyAuthentication();
- }
- else
- {
-     builder.Services.UseAuthentication();
- }
+ builder.Services.UseAuthentication();

[linkdotnet]

That works:

The only thing is probably I would drop the name from "Logout" - so for me no "Logout Steven Giesel". I understand that we should have the name somewhere.

I was also playing with the idea of:

1. Having the Author name in the preview:

2. And somewhere here:

EDIT: Of course that is if the multi author mode is enabled.

edit 2: But somewhere it might be useful to show the username in the UI.

[Arnab-Developer]

@linkdotnet it is good news that the solution is working with identity provider's claim information. Let me know when you will find a good place to show the AuthorName. We will update the PR based on that.

[linkdotnet]

Sorry swamped with work - if you have other ideas rather than next to "Logout"/"Login" - I am open. On top of my head, we can keep the Lock icon and instead of "Logout" we put the Name in.

[Arnab-Developer]

When multi user mode is enable, then we can show the author name at the place of logout. If someone clicks on the author name then a drop down will open and logout link will be inside that. Do you like this idea?

[linkdotnet]

When multi user mode is enable, then we can show the author name at the place of logout. If someone clicks on the author name then a drop down will open and logout link will be inside that. Do you like this idea?

Yeah - that sounds good. That in combination with the two places where the author should be visible and the feature is done

[Arnab-Developer]

Do you also want to show the author name in the blog preview page?

[linkdotnet]

Do you also want to show the author name in the blog preview page?

Yes indeed - otherwise the feature would not have much impact at all.

And:

[linkdotnet]

If the flag is true

[Arnab-Developer]

Ok, I will update the PR accordingly.

[Arnab-Developer]

I have made the code changes. Please review.

[linkdotnet]

Really good. Sorry for the late reply, I am unfortunately a bit sick. I only want one last change to align to the current style:

Here an icon is missing. I would take the same as in the menuband:

<i class="user-tie"></i> @AuthorName

The same is true for the Blog Post Page itself.

[Arnab-Developer]

Icon added. Please review when you feel better.

[linkdotnet]

LGTM - there are some super minor things with the alignment, but I will fix them on the master branch.

[samcov]

Great job guys!!!