Skip to content

Assert column names for partial views #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Assert column names for partial views #121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c0f275
Assert column names for partial views
jogrogan Mar 17, 2025
3b2bbb7
Merge branch 'main' into jogrogan/colVerify
jogrogan Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions hoptimator-util/src/main/java/com/linkedin/hoptimator/util/planner/PipelineRel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,13 @@ public Function<SqlDialect, String> sql(Properties connectionProperties) throws
RelDataType targetRowType = sinkRowType;
if (targetRowType == null) {
targetRowType = query.getRowType();
} else {
// Assert target fields exist in the sink schema when the sink schema is known (partial view use case)
for (String fieldName : targetFields.rightList()) {
if (!targetRowType.getFieldNames().contains(fieldName)) {
throw new IllegalArgumentException("Field " + fieldName + " not found in sink schema");
}
}
}
Map<String, String> sinkConfigs = ConnectionService.configure(sink, connectionProperties);
script = script.database(sink.schema());
Expand Down