Skip to content

Add logging for deployers #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jogrogan merged 2 commits into from
Mar 19, 2025
Merged

Add logging for deployers #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98d84ad
Add logging for deployers
jogrogan Mar 19, 2025
eccc43e
Merge branch 'main' into jogrogan/logging
jogrogan Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions hoptimator-k8s/src/main/java/com/linkedin/hoptimator/k8s/K8sApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
import java.util.List;
import java.util.Map;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import io.kubernetes.client.common.KubernetesListObject;
import io.kubernetes.client.common.KubernetesObject;
import io.kubernetes.client.openapi.models.V1OwnerReference;
Expand All @@ -19,6 +22,7 @@


public class K8sApi<T extends KubernetesObject, U extends KubernetesListObject> implements Api<T> {
private final static Logger log = LoggerFactory.getLogger(K8sApi.class);

private final K8sContext context;
private final K8sApiEndpoint<T, U> endpoint;
Expand Down Expand Up @@ -103,6 +107,7 @@ public void create(T obj) throws SQLException {
context.own(obj);
KubernetesApiResponse<T> resp = context.<T, U>generic(endpoint).create(obj);
checkResponse(resp);
log.info("Created K8s obj: {}:{}", obj.getKind(), obj.getMetadata().getName());
}

@Override
Expand All @@ -113,6 +118,7 @@ public void delete(T obj) throws SQLException {
KubernetesApiResponse<T> resp =
context.<T, U>generic(endpoint).delete(obj.getMetadata().getNamespace(), obj.getMetadata().getName());
checkResponse(resp);
log.info("Deleted K8s obj: {}:{}", obj.getKind(), obj.getMetadata().getName());
}

@Override
Expand Down Expand Up @@ -156,6 +162,7 @@ public void update(T obj) throws SQLException {
resp = context.<T, U>generic(endpoint).create(obj);
}
checkResponse(resp);
log.info("Updated K8s obj: {}:{}", obj.getKind(), obj.getMetadata().getName());
}

public void updateStatus(T obj, Object status) throws SQLException {
Expand All @@ -164,6 +171,7 @@ public void updateStatus(T obj, Object status) throws SQLException {
}
KubernetesApiResponse<T> resp = context.<T, U>generic(endpoint).updateStatus(obj, x -> status);
checkResponse(resp);
log.info("Updated K8s obj status: {}:{}", obj.getKind(), obj.getMetadata().getName());
}

private void checkResponse(KubernetesApiResponse<?> resp) throws SQLException {
Expand Down
7 changes: 7 additions & 0 deletions hoptimator-k8s/src/main/java/com/linkedin/hoptimator/k8s/K8sYamlApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
import java.util.HashMap;
import java.util.Map;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import io.kubernetes.client.openapi.ApiException;
import io.kubernetes.client.util.generic.KubernetesApiResponse;
import io.kubernetes.client.util.generic.dynamic.DynamicKubernetesObject;
Expand All @@ -14,6 +17,7 @@


public class K8sYamlApi implements Api<String> {
private final static Logger log = LoggerFactory.getLogger(K8sYamlApi.class);

private final K8sContext context;

Expand All @@ -33,6 +37,7 @@ public void create(String yaml) throws SQLException {
KubernetesApiResponse<DynamicKubernetesObject> resp =
context.dynamic(obj.getApiVersion(), K8sUtils.guessPlural(obj)).create(obj);
checkResponse(yaml, resp);
log.info("Created K8s obj: {}:{}", obj.getKind(), obj.getMetadata().getName());
}

@Override
Expand All @@ -42,6 +47,7 @@ public void delete(String yaml) throws SQLException {
context.dynamic(obj.getApiVersion(), K8sUtils.guessPlural(obj))
.delete(obj.getMetadata().getNamespace(), obj.getMetadata().getName());
checkResponse(yaml, resp);
log.info("Deleted K8s obj: {}:{}", obj.getKind(), obj.getMetadata().getName());
}

@Override
Expand Down Expand Up @@ -70,6 +76,7 @@ public void update(String yaml) throws SQLException {
resp = context.dynamic(obj.getApiVersion(), K8sUtils.guessPlural(obj)).create(obj);
}
checkResponse(yaml, resp);
log.info("Updated K8s obj: {}:{}", obj.getKind(), obj.getMetadata().getName());
}

private DynamicKubernetesObject objFromYaml(String yaml) {
Expand Down