Override clear method in custom list views #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
64
to
68
| @Override | ||
| public void clear() { | ||
| utf8List.clear(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you add doc why these method need to be override, the thing you have the PR description.
dg-builder
approved these changes
Apr 24, 2024
dg-builder
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Overriding clear method in List views to run clear methods of provided list rather than defaulting on AbstractList implementation.
Why
Generic Array implementation in avro has custom implementation of clear, which is lost if AbstractList's method is used.
Test
build