Add for utf8 method in String/Utf8/Charsequence ListViews #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-ukumar
changed the title
Comment on lines
+52
to
+55
| public void add(int index, Utf8 element) { | ||
| _utf8List.add(index, element); | ||
| } | ||
|
|
There was a problem hiding this comment.
no such method in the base class?
There was a problem hiding this comment.
No. Base class only has methods for String in this case.. (Since we are extending AbstractList).
| @@ -38,16 +38,30 @@ public String set(int index, String element) { | |||
| return previousValue; | |||
| } | |||
|
|
|||
| public String set(int index, Utf8 element) { | |||
There was a problem hiding this comment.
should add this method in base class/interface?
There was a problem hiding this comment.
Base class is java's AbstractList. We cant modify that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Test