Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iceberg-azure v1.5.0 package loading #188

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

jcamachor
Copy link
Contributor

@jcamachor jcamachor commented Sep 7, 2024

Summary

This PR addresses an issue encountered during smoke tests for the OpenHouse deployment, specifically related to Iceberg ADLS dependencies. The issue is caused by the inclusion of the iceberg-azure package 1.5.0 in the Spark client script, which pulled in conflicting dependencies and caused java.io.InvalidClassException errors in the workers.

The fix involves removing the org.apache.iceberg:iceberg-azure:1.5.0 dependency from the script, as OpenHouse already has the necessary ADLS file IO implementation bundled within the project. This resolves the incompatibility and allows the deployment to proceed without errors.

Changes

  • Client-facing API Changes
  • Internal API Changes
  • Bug Fixes
  • New Features
  • Performance Improvements
  • Code Style
  • Refactoring
  • Documentation
  • Tests

Removed the org.apache.iceberg:iceberg-azure:1.5.0 package from the Spark client script.

Testing Done

  • Manually Tested on local docker setup. Please include commands ran, and their output.
  • Added new tests for the changes made.
  • Updated existing tests to reflect the changes made.
  • No tests added or updated. Please explain why. If unsure, please feel free to ask for help.
  • Some other form of testing like staging or soak time in production. Please explain.

Tested in Azure deployment.

@sumedhsakdeo sumedhsakdeo merged commit 896320a into linkedin:main Sep 7, 2024
1 check passed
@jcamachor jcamachor deleted the iceberg_incompatible_class branch September 7, 2024 20:25
chenselena pushed a commit to chenselena/openhouse that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants