Add table policies as stats to Table Stats Collector #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenselena
commented
Sep 18, 2024
apps/spark/src/main/java/com/linkedin/openhouse/jobs/util/TableStatsCollectorUtil.java
Outdated
Show resolved
Hide resolved
maluchari
reviewed
Sep 18, 2024
services/common/src/main/java/com/linkedin/openhouse/common/stats/model/BaseTableMetadata.java
Outdated
Show resolved
Hide resolved
chenselena
force-pushed
the
selchen/update-stats-collector-table-policies
branch
2 times, most recently
from
691a6f0
to
d56291e
Compare
chenselena
force-pushed
the
selchen/update-stats-collector-table-policies
branch
from
d56291e
to
f4c74f1
Compare
chenselena
changed the title
maluchari
reviewed
Sep 18, 2024
apps/spark/src/main/java/com/linkedin/openhouse/jobs/util/TableStatsCollectorUtil.java
Outdated
Show resolved
Hide resolved
maluchari
reviewed
Sep 18, 2024
apps/spark/src/test/java/com/linkedin/openhouse/jobs/spark/OperationsTest.java
Outdated
Show resolved
Hide resolved
maluchari
reviewed
Sep 20, 2024
apps/spark/src/main/java/com/linkedin/openhouse/jobs/util/TableStatsCollectorUtil.java
Outdated
Show resolved
Hide resolved
maluchari
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR captures table policies (
sharingEnabledandretention) in the table stats collector to use for Openhouse alerting.Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Added unit test to test that the policies are correctly set in the stats collector.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.