Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wildcard based matching for togglestatus endpoint #203

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

autumnust
Copy link
Collaborator

Summary

This PR contains logically two components:

  • The changes in iceberg/openhouse/internalcatalog/src/main/java/com/linkedin/openhouse/internal/catalog/OpenHouseInternalCatalog.java is due to the discovery in the testing phase that the an inheritance doesn't apply for annotation and AOP's proxy model requires the annotation to be applied on the object that got directly invoked. Thus the annotation in this createTable is not necessary. Since adding annotation was the only reason why rewriting this method, removing this whole method doesn't change any behavior.
  • The main part of this PR is to add wildcard matching for hts/togglestatus endpoint, so that for features like temporarily forbidding table-creation, we can simply insert one rule that contains wildcard for both tableId and databaseId.

Changes

  • Client-facing API Changes
  • Internal API Changes
  • Bug Fixes
  • New Features
  • Performance Improvements
  • Code Style
  • Refactoring
  • Documentation
  • Tests

For all the boxes checked, please include additional details of the changes made in this pull request.

Testing Done

Adding the proper unit tests for the new beans added

  • Manually Tested on local docker setup. Please include commands ran, and their output.
  • Added new tests for the changes made.
  • Updated existing tests to reflect the changes made.
  • No tests added or updated. Please explain why. If unsure, please feel free to ask for help.
  • Some other form of testing like staging or soak time in production. Please explain.

For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.

Additional Information

  • Breaking Changes
  • Deprecations
  • Large PR broken into smaller PRs, and PR plan linked in the description.

For all the boxes checked, include additional details of the changes made in this pull request.

@autumnust autumnust merged commit d9f99ce into main Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants