Support wildcard based matching for togglestatus endpoint #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains logically two components:
iceberg/openhouse/internalcatalog/src/main/java/com/linkedin/openhouse/internal/catalog/OpenHouseInternalCatalog.java
is due to the discovery in the testing phase that the an inheritance doesn't apply for annotation and AOP's proxy model requires the annotation to be applied on the object that got directly invoked. Thus the annotation in thiscreateTable
is not necessary. Since adding annotation was the only reason why rewriting this method, removing this whole method doesn't change any behavior.hts/togglestatus
endpoint, so that for features like temporarily forbidding table-creation, we can simply insert one rule that contains wildcard for both tableId and databaseId.Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
Adding the proper unit tests for the new beans added
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.