Add an option to configure Job specific timeout values #206
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teamurko
requested changes
Sep 20, 2024
apps/spark/src/main/java/com/linkedin/openhouse/jobs/scheduler/JobsScheduler.java
Outdated
Show resolved
Hide resolved
| @@ -63,7 +63,7 @@ | |||
| */ | |||
| @Slf4j | |||
| public class JobsScheduler { | |||
| private static final int TASKS_WAIT_TIMEOUT_HOURS = 12; | |||
| private static final int DEFAULT_TASKS_WAIT_TIMEOUT_HOURS = 12; | |||
There was a problem hiding this comment.
Suggested change
| private static final int DEFAULT_TASKS_WAIT_TIMEOUT_HOURS = 12; | |
| private static final int DEFAULT_TASKS_WAIT_HOURS = 12; |
apps/spark/src/main/java/com/linkedin/openhouse/jobs/scheduler/JobsScheduler.java
Outdated
Show resolved
Hide resolved
apps/spark/src/main/java/com/linkedin/openhouse/jobs/scheduler/JobsScheduler.java
Outdated
Show resolved
Hide resolved
teamurko
previously approved these changes
Sep 20, 2024
apps/spark/src/main/java/com/linkedin/openhouse/jobs/scheduler/JobsScheduler.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current default value of timeout is 12 hours. Since how long an entire job can take depend on number of tables and also on concurreny, making the timeout configurable in this PR.
Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.