refactor: Move agent env config and fix lints

[AustinChangLinksys]

User description

Moves env template to assets/agents and fixes analysis warnings.

---

PR Type

Tests, Enhancement

---

Description

• Updated Mockito mock files from version 5.4.4/5.4.5 to 5.4.6 across multiple notifier mocks (auth_notifier, internet_settings_notifier, device_manager_notifier, dashboard_manager_notifier, node_detail_notifier, dashboard_home_notifier, polling_notifier)

• Fixed analysis warnings by adding const declarations to list and dictionary literals throughout test files for proper const optimization

• Added missing braces to if/if-else statements in production code (internet_settings_form_validator.dart, pppoe_form.dart, transaction_http_command.dart) for code style compliance

• Removed unused imports and variables from test files to reduce analysis warnings

• Renamed private helper functions and variables by removing underscore prefixes in test files (input_validators_test.dart, pnp_isp_service_test.dart)

• Added invalid_use_of_internal_member and must_be_immutable ignore directives to mock files

• Changed mock class inheritance patterns to extend _i1.Mock instead of specific notifier types

• Added comprehensive architecture analysis documentation identifying coupling violations and remediation strategies

---

Diagram Walkthrough

flowchart LR
  A["Mockito 5.4.4/5.4.5"] -- "Update version" --> B["Mockito 5.4.6"]
  C["Analysis Warnings"] -- "Fix const declarations" --> D["Optimized const literals"]
  E["Missing braces"] -- "Add braces" --> F["Code style compliance"]
  G["Unused imports/variables"] -- "Remove" --> H["Cleaner codebase"]
  I["Architecture Issues"] -- "Document violations" --> J["Remediation guide"]

Loading

File Walkthrough

	Relevant files
Tests	7 files auth_notifier_mocks.dart Update Mockito mocks to version 5.4.6 with new auth methods test/mocks/auth_notifier_mocks.dart Updated Mockito version from 5.4.5 to 5.4.6 in generated mock file Reorganized import aliases and added new import for guardians_remote_assistance.dart Changed MockAuthNotifier to extend _i1.Mock instead of _i2.AsyncNotifier Added new methods cloudLoginAuth, testSessionAuthentication, and future getter Reformatted method signatures with improved code formatting and line breaks Added invalid_use_of_internal_member ignore directive +259/-156 internet_settings_notifier_mocks.dart Update internet settings notifier mocks to 5.4.6                  test/mocks/internet_settings_notifier_mocks.dart Updated Mockito version from 5.4.5 to 5.4.6 Removed unused imports for dummies.dart and better_action.dart Changed MockInternetSettingsNotifier to extend _i1.Mock instead of _i2.Notifier Updated return types from InternetSettings to InternetSettingsUIModel Removed methods getSaveIpv4Transactions, getSaveIpv6Transactions, and getMacAddressCloneTransaction Added invalid_use_of_internal_member ignore directive +35/-91  device_manager_notifier_mocks.dart Update device manager notifier mocks to 5.4.6                        test/mocks/device_manager_notifier_mocks.dart Updated Mockito version from 5.4.4 to 5.4.6 Changed MockDeviceManagerNotifier to extend _i1.Mock instead of _i2.Notifier Removed createState method and added init method Added listenSelf method implementation Added must_be_immutable and invalid_use_of_internal_member ignore directives Reorganized import aliases +48/-46  dashboard_manager_notifier_mocks.dart Update dashboard manager notifier mocks to 5.4.6                  test/mocks/dashboard_manager_notifier_mocks.dart Updated Mockito version from 5.4.4 to 5.4.6 Changed mock file source from login test to dashboard manager spec Changed MockDashboardManagerNotifier to extend _i1.Mock instead of _i2.Notifier Removed createState method and reordered methods Added listenSelf method implementation Added must_be_immutable and invalid_use_of_internal_member ignore directives +57/-53  node_detail_notifier_mocks.dart Update node detail notifier mocks to 5.4.6                              test/mocks/node_detail_notifier_mocks.dart Updated Mockito version from 5.4.4 to 5.4.6 Changed MockNodeDetailNotifier to extend _i1.Mock instead of _i2.Notifier Removed _FakeJNAPResult_2 class and related methods startBlinkNodeLED and stopBlinkNodeLED Added listenSelf method implementation Added must_be_immutable and invalid_use_of_internal_member ignore directives +35/-72  dashboard_home_notifier_mocks.dart Update dashboard home notifier mocks to 5.4.6                        test/mocks/dashboard_home_notifier_mocks.dart Updated Mockito version from 5.4.4 to 5.4.6 Removed unused imports for dashboard manager and device manager states, health check state Changed MockDashboardHomeNotifier to extend _i1.Mock instead of _i2.Notifier Added invalid_use_of_internal_member ignore directive +2/-47    polling_notifier_mocks.dart Update polling notifier mocks to 5.4.6                                      test/mocks/polling_notifier_mocks.dart Updated Mockito version from 5.4.5 to 5.4.6 Removed unused import for dummies.dart Changed MockPollingNotifier to extend _i1.Mock instead of _i2.AsyncNotifier Added invalid_use_of_internal_member ignore directive +2/-27
Formatting	28 files ipv6_port_service_list_service_test.dart Fix const list formatting in IPv6 firewall tests                  test/page/advanced_settings/firewall/services/ipv6_port_service_list_service_test.dart Changed list literals from [const ...] to const [...] for proper const optimization Removed redundant const keywords from individual PortRange items within const lists Applied formatting consistently across multiple test cases +35/-35  input_validators_test.dart Remove private underscore prefixes from test helper functions test/validator_rules/input_validators_test.dart Added avoid_print ignore directive at file header Renamed private variables from _testResults, _trackTestResult, _printTestSummary, _runInvalidTestCases to public versions without underscore prefix Updated all references to renamed functions and variables throughout the test file +24/-22  jnap_tr181_mapper.dart Add const declarations and fix if-else braces                        lib/core/usp/jnap_tr181_mapper.dart Changed mockParentIp from variable to const declaration Added missing braces to if-else statements for code style compliance Improved code formatting consistency in WAN connection status logic +13/-9    internet_settings_service_test.dart Fix const list formatting in internet settings tests          test/page/advanced_settings/internet_settings/services/internet_settings_service_test.dart Changed list literals from [MapEntry(...)] to const [MapEntry(...)] for const optimization Removed redundant const keywords from individual JNAPSuccess items within const lists Applied consistent const formatting across multiple test data setups +16/-16  firmware_update_service_test.dart Add const declarations to test data dictionaries                  test/core/jnap/services/firmware_update_service_test.dart Changed dictionary literals from {...} to const {...} for const optimization Applied const formatting to output dictionaries in test mocks +4/-4      internet_settings_form_validator.dart Add braces to if statements in form validator                        lib/page/advanced_settings/internet_settings/utils/internet_settings_form_validator.dart Added missing braces to if statements for code style compliance Improved code formatting consistency across validation methods +8/-4      ipv6_port_service_list_provider_test.dart Remove unused variables and fix const formatting                  test/page/advanced_settings/firewall/providers/ipv6_port_service_list_provider_test.dart Removed unused state variable assignments in two test cases Changed list literals to use const keyword for const optimization Reorganized portRanges from const [...] to [...] within non-const parent lists +5/-7      manual_firmware_update_provider_test.dart Add const declarations to test file names                                test/page/instant_admin/providers/manual_firmware_update_provider_test.dart Changed fileName variable declarations from final to const for const optimization Applied const formatting consistently across multiple test cases +5/-5      pnp_isp_service_test.dart Remove private underscore prefix from helper function        test/page/instant_setup/troubleshooter/services/pnp_isp_service_test.dart Renamed private helper function _baseWanStatusOutput to public baseWanStatusOutput Updated all references to use the renamed function +5/-5      channel_finder_service_test.dart Remove unused imports and add const declarations                  test/page/wifi_settings/services/channel_finder_service_test.dart Removed unused imports for flutter_riverpod and channelfinder_info Changed dictionary literals from {...} to const {...} for const optimization +3/-5      firewall_state_test.dart Remove redundant const from EmptyStatus instances                test/page/advanced_settings/firewall/providers/firewall_state_test.dart Changed EmptyStatus() from const EmptyStatus() to EmptyStatus() for consistency Applied formatting changes across multiple test cases +7/-7      dmz_settings_state_test.dart Remove redundant const from DMZStatus instances                    test/page/advanced_settings/dmz/providers/dmz_settings_state_test.dart Changed DMZStatus() from const DMZStatus() to DMZStatus() for consistency Applied formatting changes across multiple test cases +7/-7      static_routing_state_test.dart Remove unused import and add const declarations                    test/page/advanced_settings/static_routing/providers/static_routing_state_test.dart Removed unused import for dart:convert Changed empty list literals from [] to const [] for const optimization Applied const formatting consistently across test cases +6/-7      dmz_settings_service_test.dart Remove unused import and add const declarations                    test/page/advanced_settings/dmz/services/dmz_settings_service_test.dart Removed unused import for dmz_settings.dart Changed dictionary literals from {} to const {} for const optimization +2/-3      internet_settings_ui_model_test.dart Fix const declaration syntax in model tests                            test/page/advanced_settings/internet_settings/models/internet_settings_ui_model_test.dart Changed variable declarations from final const to const for proper const syntax Applied const formatting consistently across test cases +4/-4      instant_safety_service_test.dart Add const declarations to test data dictionaries                  test/page/instant_safety/services/instant_safety_service_test.dart Changed dictionary literals from {} to const {} for const optimization Applied const formatting to output dictionaries in test mocks +3/-3      port_range_forwarding_test_data.dart Add const declarations to test data                                            test/mocks/test_data/port_range_forwarding_test_data.dart Changed list literals from [] to const [] for const optimization Changed dictionary literals from {...} to const {...} Reorganized nested const declarations for consistency +3/-3      port_range_triggering_service_test.dart Fix const list formatting in port triggering tests              test/page/advanced_settings/apps_and_gaming/ports/services/port_range_triggering_service_test.dart Changed list literals from [const ...] to const [...] for proper const optimization Removed redundant const keywords from individual items within const lists +5/-5      port_range_forwarding_service_test.dart Fix const list formatting in port forwarding tests              test/page/advanced_settings/apps_and_gaming/ports/services/port_range_forwarding_service_test.dart Changed list literals from [const ...] to const [...] for proper const optimization Removed redundant const keywords from individual items within const lists +5/-5      pppoe_form.dart Add braces to if statements in focus listeners                      lib/page/advanced_settings/internet_settings/widgets/wan_forms/pppoe_form.dart Added missing braces to if statements in focus node listeners Improved code formatting consistency +4/-2      polling_test_data.dart Add const declarations to polling test data                            test/mocks/test_data/polling_test_data.dart Changed dictionary literals from {...} to const {...} for const optimization Applied const formatting to test data outputs +2/-2      instant_verify_ui_models_test.dart Add const declarations to test data lists                                test/page/instant_verify/models/instant_verify_ui_models_test.dart Changed list literals from [...] to const [...] for const optimization Applied const formatting consistently across test cases +4/-4      timezone_service_test.dart Fix const declaration syntax in timezone tests                      test/page/instant_admin/services/timezone_service_test.dart Changed variable declarations from final const to const for proper const syntax Applied const formatting consistently across test cases +3/-3      generate_screenshot_test_cases_report.dart Add ignore directive and fix if statement braces                  tools/generate_screenshot_test_cases_report.dart Added avoid_print ignore directive at file header Added missing braces to if statements for code style compliance +6/-2      ipv6_port_service_rule_state_test.dart Add const declarations to rule state test data                      test/page/advanced_settings/firewall/providers/ipv6_port_service_rule_state_test.dart Changed dictionary literals from {...} to const {...} for const optimization Applied const formatting to test data inputs +3/-3      transaction_http_command.dart Replace forEach with for loop in transaction command          lib/core/jnap/command/http/transaction_http_command.dart Changed forEach loop to traditional for loop for better readability Improved code style consistency +2/-2      dashboard_manager_test_data.dart Add const declarations to dashboard manager test data        test/mocks/test_data/dashboard_manager_test_data.dart Changed list literals from [...] to const [...] for const optimization Changed dictionary literals from {...} to const {...} for const optimization +2/-2      ddns_test_data.dart Add const declarations to DDNS test data                                  test/mocks/test_data/ddns_test_data.dart Changed list literals from [...] to const [...] for const optimization Applied const formatting consistently across test data +3/-3
Documentation	1 files architecture_analysis_2026-01-05.md Comprehensive architecture analysis with coupling violations and remediation guide doc/analysis/architecture_analysis_2026-01-05.md Added comprehensive architecture analysis report for PrivacyGUI project evaluating module decoupling and layer separation Documented ideal 4-layer architecture (Data/Service/Application/Presentation) with detailed diagrams and code examples Identified 5 critical coupling violations where Provider layer directly imports core/jnap/models/ (firmware_update_settings, back_haul_info, auto_configuration_settings) Analyzed cross-page Provider dependencies with dependency graphs and risk assessment matrix, identifying 3 high-risk coupling hotspots Provided detailed remediation suggestions with code examples for each violation, including creation of UI-specific models and Service layer refactoring Included verification commands, priority matrix for fixes, and overall architecture scoring (3.6/5 stars) +727/-0
Additional files	63 files ci.yml +1/-1      env.template [link]    wirless_connection.dart +1/-1      main.dart +1/-1      main_demo.dart +1/-1      ipv4_connection_view.dart +0/-1      ipv6_connection_view.dart +0/-1      release_and_renew_view.dart +0/-1      optional_settings_form.dart +0/-1      automatic_ipv6_form.dart +0/-1      pptp_form.dart +0/-1      idle_checker.dart +1/-1      manual_firmware_update_view.dart +1/-1      instant_safety_service.dart +2/-0      pnp_isp_settings_provider.dart +0/-1      pnp_isp_type_selection_view.dart +0/-1      pnp_pppoe_view.dart +0/-1      pnp_static_ip_view.dart +0/-1      route_add_nodes.dart +1/-1      route_cloud_login.dart +1/-1      route_dashboard.dart +1/-1      route_home.dart +1/-1      route_pnp.dart +1/-1      utils.dart +1/-1      usp_topology_service.dart +1/-1      usp_protobuf_converter.dart +0/-7      pubspec.yaml +1/-2      utils.dart +0/-1      dashboard_home_test_data.dart +1/-1      port_range_triggering_test_data.dart +1/-1      single_port_forwarding_test_data.dart +1/-1      static_routing_test_data.dart +0/-1      ddns_provider_test.dart +1/-1      dmz_status_test.dart +1/-1      dmz_settings_service_test_data.dart +1/-1      firewall_provider_test.dart +0/-1      firewall_settings_service_test.dart +0/-2      ipv6_port_service_list_service_test_data.dart +2/-2      internet_settings_view_test.dart +0/-1      dhcp_reservations_provider_test.dart +1/-1      dhcp_reservations_state_test.dart +0/-1      local_network_settings_state_test.dart +0/-2      static_route_entry_ui_model_test.dart +1/-1      static_routing_rule_ui_model_test.dart +1/-1      static_routing_rule_provider_test.dart +0/-2      static_routing_service_test.dart +0/-1      snack_bar_test.dart +1/-2      loading_tile_test.dart +0/-1      health_check_provider_test.dart +1/-1      timezone_state_test.dart +0/-1      router_password_service_test.dart +0/-1      instant_privacy_state_test.dart +2/-2      pnp_step_state_test.dart +1/-1      pnp_isp_settings_provider_test.dart +0/-1      instant_verify_provider_test.dart +1/-1      instant_verify_state_test.dart +2/-2      wifi_advanced_state_test.dart +1/-1      wifi_state_test.dart +2/-2      utils_test.dart +2/-0      combine_results.dart +2/-0      test_result_parser.dart +2/-0      remove_unused_strings.dart +2/-0      run_screenshot_tests.dart +2/-0

---

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
High-level	Implement the documented architectural fixes The PR adds an architecture analysis document identifying critical issues but doesn't implement the fixes. The suggestion is to act on this analysis by creating subsequent PRs to address the documented architectural debt. Examples: doc/analysis/architecture_analysis_2026-01-05.md [107-166] #### 3.4 Provider 層直接引用 Data 模型 (詳細分析) **問題**: Provider 層直接 import `core/jnap/models/`，違反層次分離原則。 --- ##### 3.4.1 `auto_parent_first_login_provider.dart` **檔案位置**: `lib/page/login/auto_parent/providers/auto_parent_first_login_provider.dart` ... (clipped 50 lines) Solution Walkthrough: Before: // In a provider file like `add_nodes_provider.dart` (Application Layer) // This code exists in the codebase and is identified as a problem // by the new documentation added in this PR. import 'package:privacy_gui/core/jnap/models/back_haul_info.dart'; // ⚠️ Direct import of Data Layer model class AddNodesNotifier extends Notifier { List<BackHaulInfoData> backhaulInfoList = []; // ⚠️ Uses Data model directly Stream<List<BackHaulInfoData>> pollNodesBackhaulInfo(...) { return repo.scheduledCommand(...) .transform( handleData: (result, sink) { // ⚠️ Deserialization logic is in the Application Layer final backhaulList = List.from(result.output['backhaulDevices'] ?? []) .map((e) => BackHaulInfoData.fromMap(e)).toList(); sink.add(backhaulList); }, ); } } After: // The suggestion is to apply the fixes described in the new documentation. // This would involve creating a service and a UI model. // NEW: In `add_nodes_models.dart` (UI Model for Application Layer) class BackhaulInfoUI { // ... UI-specific fields static BackhaulInfoUI fromData(BackHaulInfoData data) { ... } } // NEW: In `add_nodes_service.dart` (Service Layer) import 'package:privacy_gui/core/jnap/models/back_haul_info.dart'; // ✅ Import is OK here class AddNodesService { Stream<List<BackhaulInfoUI>> pollNodesBackhaulInfo(...) { return repo.scheduledCommand(...).map((result) { // ✅ Logic is now in the Service Layer final dataModels = ... .map((e) => BackHaulInfoData.fromMap(e)); return dataModels.map((dm) => BackhaulInfoUI.fromData(dm)).toList(); }); } } // In `add_nodes_provider.dart` (Application Layer) - CLEANED class AddNodesNotifier extends Notifier { // ✅ Provider now calls the service and uses the UI model Stream<List<BackhaulInfoUI>> pollNodesBackhaulInfo(...) { return ref.read(addNodesServiceProvider).pollNodesBackhaulInfo(...); } } Suggestion importance[1-10]: 8 __ Why: The suggestion correctly observes that the PR adds a crucial architecture analysis document but does not implement the proposed fixes, highlighting the need to act on the identified architectural debt.	Medium
Possible issue	Load environment file from asset bundle To prevent failures in release builds, load the .env file from the asset bundle using rootBundle.loadString() instead of directly from the file system with dotenv.load(). lib/main_demo.dart [40-44] try { - await dotenv.load(fileName: 'assets/agents/.env'); + // Load the file from assets and parse it + final envString = await rootBundle.loadString('assets/agents/.env'); + dotenv.test(fromContents: envString); } catch (e) { - debugPrint('No .env file found, using defaults'); + debugPrint('Could not load .env file from assets, using defaults: $e'); } Apply / Chat Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies that dotenv.load() reads from the file system, which will fail in release builds, and proposes a robust solution using rootBundle to load the file from assets, preventing a potential runtime crash.	Medium
	Use generic types for set Improve type safety in the unique extension method by typing the Set with the generic Id or E type instead of hardcoding it as dynamic. lib/util/extensions.dart [14-24] extension Unique<E, Id> on List<E> { /// /// Returns a list containing only the unique elements. List<E> unique([Id Function(E element)? id, bool inplace = true]) { - final ids = <dynamic>{}; + final ids = id != null ? <Id>{} : <E>{}; var list = inplace ? this : List<E>.from(this); if (list.isEmpty) { return list; } list.retainWhere((x) => ids.add(id != null ? id(x) : x)); return list; } } [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 6 __ Why: The suggestion correctly improves type safety by using generic types for the Set instead of dynamic, which is a good practice for maintainability and robustness.	Low
Update