fix: update TracedClient to use wrappedruntimeclient.DefaultDecorator#1052
Open
ChihweiLHBird wants to merge 2 commits into
Open
fix: update TracedClient to use wrappedruntimeclient.DefaultDecorator#1052ChihweiLHBird wants to merge 2 commits into
wrappedruntimeclient.DefaultDecorator#1052ChihweiLHBird wants to merge 2 commits into
Conversation
Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
ChihweiLHBird
had a problem deploying
to
prod-external
GitHub Actions
Failure
ChihweiLHBird
had a problem deploying
to
prod-external
GitHub Actions
Failure
There was a problem hiding this comment.
Pull request overview
This PR fixes the tracing decorator used when creating a traced controller-runtime client, switching from the runtime reconciler decorator to the runtime client decorator.
Changes:
- Update
TracedClient()in the LinodeFirewall controller to usewrappedruntimeclient.DefaultDecorator(). - Update
TracedClient()in the LinodeCluster controller to usewrappedruntimeclient.DefaultDecorator().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/controller/linodefirewall_controller.go | Fixes TracedClient() to use the runtimeclient tracing decorator (instead of runtimereconciler). |
| internal/controller/linodecluster_controller.go | Fixes TracedClient() to use the runtimeclient tracing decorator (instead of runtimereconciler). |
ChihweiLHBird
requested a deployment
to
prod-external
GitHub Actions
Waiting
ChihweiLHBird
requested a deployment
to
prod-external
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if there was a historic reason, but this seems to be a typo to me. It wraps a client so it should use
wrappedruntimeclient, right?