Skip to content

feat: Remove defaultregion #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nolancon merged 1 commit into from
Jul 18, 2025
Merged

feat: Remove defaultregion #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions internal/rgw/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ import (
"github.com/linode/provider-ceph/internal/utils"
)

const (
defaultRegion = "us-east-1"
)

func NewS3Client(ctx context.Context, data map[string][]byte, pcSpec *apisv1alpha1.ProviderConfigSpec, s3Timeout time.Duration, sessionToken *string) (*s3.Client, error) {
sessionConfig, err := buildSessionConfig(ctx, data)
if err != nil {
Expand Down Expand Up @@ -78,7 +74,6 @@ func buildSessionConfig(ctx context.Context, data map[string][]byte) (aws.Config
return config.LoadDefaultConfig(ctx,
config.WithRetryMaxAttempts(retry.DefaultRetry.Steps),
config.WithRetryMode(aws.RetryModeStandard),
config.WithRegion(defaultRegion),
config.WithCredentialsProvider(credentials.NewStaticCredentialsProvider(
string(data[consts.KeyAccessKey]),
string(data[consts.KeySecretKey]),
Expand Down
Loading