Repository navigation
hfsplus: preserve FinderInfo when listing extended attributes - #2953
Closed
vfsci-bot[bot] wants to merge 1 commit into
Closed
vfsci-bot[bot] wants to merge 1 commit into
vfsci-bot[bot] wants to merge 1 commit into
Conversation
Commit aef5078 ("hfsplus: fix generic/062 xfstests failure") made hfsplus_listxattr() return zero when the inode has no records in the attributes B-tree. However, osx.com.apple.FinderInfo is stored in the catalog record, and hfsplus_listxattr() has already added it to the result at that point. Setting the result to zero drops it. As of now, a file whose only extended attribute is FinderInfo gets an empty list on a volume with an attributes B-tree, which mkfs.hfsplus creates by default. getxattr() still returns the value. The issue can be reproduced with: truncate -s 64M hfs.img mkfs.hfsplus hfs.img mount -o loop hfs.img /mnt touch /mnt/file v=0x54455854$(printf %056d 0) setfattr -n osx.com.apple.FinderInfo -v $v /mnt/file getfattr -m - /mnt/file Without this patch, getfattr prints nothing. With this patch, it lists the FinderInfo entry. This patch keeps the result of hfsplus_listxattr_finder_info() when no attributes B-tree records are found, as is already done when the volume has no attributes B-tree. A file without extended attributes still gets an empty list. Fixes: aef5078 ("hfsplus: fix generic/062 xfstests failure") Cc: stable@vger.kernel.org Signed-off-by: Hengyu Liang <hengyul@cs.unc.edu>
Author
|
Superseded by series 1190716 (v1). Closing automatically. Automated by ml2pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Series: https://patchwork.kernel.org/project/linux-fsdevel/list/?series=1191176
Submitter: Hengyu Liang
Version: 2
Patches: 1/1
Message-ID:
<20261022094058.1169039-1-hengyul@cs.unc.edu>Base: vfs.base.ci
Lore: https://lore.kernel.org/linux-fsdevel/20261022094058.1169039-1-hengyul@cs.unc.edu
Automated by ml2pr