tests: check_selftest: fix error wording #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while testing check_selftest on my patch, which contains the following order: CONFIG_NET_SCH_INGRESS=y CONFIG_NETCONSOLE=m It printed the following error, which is clearly wrong: Validation errors in tools/testing/selftests/drivers/net/bonding/config: Lines 14-15 invalid order, CONFIG_NETCONSOLE=m should be after CONFIG_NET_SCH_INGRESS=y Fix the wording saying that current line should come before the previous one, given there is an error and current line is already after previous line. Also rename variables to make the code easier to reason about. Signed-off-by: Breno Leitao <[email protected]> Fixes: af02b9f ("tests: make check_selftests check format of Makefiles and configs")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while testing check_selftest on my patch, which contains the following order:
It printed the following error, which is clearly wrong:
Fix the wording saying that current line should come before the previous one, given there is an error and current line is already after previous line. Also rename variables to make the code easier to reason about.
Fixes: af02b9f ("tests: make check_selftests check format of Makefiles and configs")