refactor: do not use automatic format strings

[richm]

pylint does not like automatic format strings - might be problematic on some
older platforms with older versions of python

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Enhancements:

• Replace automatic '{}' format strings with explicit positional '{0}' placeholders in error messages for compatibility and to satisfy pylint

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replace implicit field numbering in .format calls with explicit positional placeholders ({0}) across LUKS CLI helper functions to satisfy linting and maintain compatibility with older Python versions.

Class diagram for updated LUKS CLI helper functions

classDiagram
    class nbde_client_clevis_helpers {
        +get_luks1_payload_offset(module, device)
        +backup_luks1_gap_area(module, device, payload_offset_sectors)
        +restore_luks1_gap_area(module, device, payload_offset_sectors, header_and_gap_data)
        +restore_luks_device(module, device, backup)
    }
    nbde_client_clevis_helpers : uses explicit positional format strings in error messages

Loading

File-Level Changes

Change	Details	Files
Use explicit positional fields in error message formatting	Replaced "{}".format(stderr) with "{0}".format(stderr) in get_luks1_payload_offset Updated error return formatting in backup_luks1_gap_area Refactored restore_luks1_gap_area error return to use explicit field index Adjusted rollback error message in restore_luks_device to use {0}	library/nbde_client_clevis.py
Use explicit positional fields for dd command arguments	Swapped "if={}".format(device) with "if={0}".format(device) Changed "count={}".format(payload_offset_sectors) to use {0} in backup_luks1_gap_area Replaced "of={}".format(device) with explicit positional placeholder in restore_luks1_gap_area Updated count formatting in restore_luks1_gap_area to use {0}	library/nbde_client_clevis.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}