ci: skip most CI checks if title contains citest skip [citest_skip]#839
Merged
ci: skip most CI checks if title contains citest skip [citest_skip]#839
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a conditional guard to most GitHub Actions CI jobs so they are skipped when a pull request title contains the marker "[citest_skip]". Sequence diagram for conditional CI execution based on PR titlesequenceDiagram
actor Developer
participant GitHub
participant Workflow_ansible_lint
participant Workflow_codespell
participant Workflow_shellcheck
Developer->>GitHub: Open pull_request(title)
GitHub-->>Workflow_ansible_lint: Trigger workflow with event pull_request
GitHub-->>Workflow_codespell: Trigger workflow with event pull_request
GitHub-->>Workflow_shellcheck: Trigger workflow with event pull_request
alt PR title contains [citest_skip]
Workflow_ansible_lint-->>Workflow_ansible_lint: if !contains(title, [citest_skip]) is false
Workflow_codespell-->>Workflow_codespell: if !contains(title, [citest_skip]) is false
Workflow_shellcheck-->>Workflow_shellcheck: if !contains(title, [citest_skip]) is false
Workflow_ansible_lint-->>GitHub: Job skipped
Workflow_codespell-->>GitHub: Job skipped
Workflow_shellcheck-->>GitHub: Job skipped
else PR title does not contain [citest_skip]
Workflow_ansible_lint-->>Workflow_ansible_lint: if !contains(title, [citest_skip]) is true
Workflow_codespell-->>Workflow_codespell: if !contains(title, [citest_skip]) is true
Workflow_shellcheck-->>Workflow_shellcheck: if !contains(title, [citest_skip]) is true
Workflow_ansible_lint->>GitHub: Run CI checks
Workflow_codespell->>GitHub: Run CI checks
Workflow_shellcheck->>GitHub: Run CI checks
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
codeql.ymlthe job-level condition directly accessesgithub.event.pull_request.title, which will be undefined forpushandscheduleevents; consider guarding by event type (e.g.if: github.event_name != 'pull_request' || !contains(github.event.pull_request.title, '[citest_skip]')) so CodeQL analysis still runs for non-PR triggers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `codeql.yml` the job-level condition directly accesses `github.event.pull_request.title`, which will be undefined for `push` and `schedule` events; consider guarding by event type (e.g. `if: github.event_name != 'pull_request' || !contains(github.event.pull_request.title, '[citest_skip]')`) so CodeQL analysis still runs for non-PR triggers.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we submit a PR for a CI update or docs, we do not want to start CI checking
for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more
roles, this fires off a lot of unnecessary tests, which sometimes causes the
linux-system-roles org in github to be throttled.
When submitting a PR that can skip ci, use "[citest_skip]" in the PR title.