test: retry the check for masking/stopping - it may take several seconds to complete

[richm]

retry the check for masking/stopping - it may take several seconds for the unit to be
masked and to be stopped

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Tests:

• Update basic test playbook to poll systemd for masked/stopped state with retries instead of asserting immediately.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds retry logic around checking a systemd unit’s masked/stopped state in the basic tests so the test tolerates the delay before the unit reaches its final state.

File-Level Changes

Change	Details	Files
Convert single-shot assertion of systemd unit state into a retried check with timeout semantics.	Rename the task to reflect that it both fetches and checks the unit status in one step. Keep using systemctl show to inspect UnitFileState and SubState but wrap it in Ansible’s until/retries/delay loop to poll for the desired state. Replace the separate assert task with an inline boolean condition variable that encodes the masked-or-bad and dead SubState requirements and drives until/failed_when. Configure the polling to retry up to 6 times with a 10-second delay between retries to allow for slow masking/stopping operations.	tests/tests_basic.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The condition variable is defined using test_unit_state within the same task that registers test_unit_state, which won’t be available at variable-evaluation time; consider inlining the expression directly in until/failed_when (e.g. until: test_unit_state.stdout is search(...)), or moving the condition into a separate task.
• Using both until: condition and failed_when: not condition is redundant; you can rely on until alone (drop failed_when) or invert the condition and keep only one mechanism to simplify the task logic.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The `condition` variable is defined using `test_unit_state` within the same task that registers `test_unit_state`, which won’t be available at variable-evaluation time; consider inlining the expression directly in `until`/`failed_when` (e.g. `until: test_unit_state.stdout is search(...)`), or moving the condition into a separate task.
- Using both `until: condition` and `failed_when: not condition` is redundant; you can rely on `until` alone (drop `failed_when`) or invert the condition and keep only one mechanism to simplify the task logic.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[richm]

[citest]