Remove epoll() usage in LTX communication #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using epoll() is a bad idea when asyncio is involved. The reason is that asyncio itself is using epoll() to implement concurrency, so we end up having 2 epoll() instances running in parallel. When we record a new file descriptor into an asyncio application, we supposed to use the asyncio.BaseEventLoop.add_reader() method which is, unfortunately, not working (by experience) with plain files. For this reason, the current solution is to use threaded read() syscall which permits to execute reading operations, as well as keeping asyncio loop running in the background without killing UI or data acquisition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using epoll() is a bad idea when asyncio is involved. The reason is that asyncio itself is using epoll() to implement concurrency, so we end up having 2 epoll() instances running in parallel. When we record a new file descriptor into an asyncio application, we supposed to use the asyncio.BaseEventLoop.add_reader() method which is, unfortunately, not working (by experience) with plain files.
For this reason, the current solution is to use threaded read() syscall which permits to execute reading operations, as well as keeping asyncio loop running in the background without killing UI or data acquisition.