Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复旧版控制中心无法加入内测的问题 #129

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

ArchieMeng
Copy link
Contributor

将其加入允许安装的列表

Bug: https://pms.uniontech.com/bug-view-273975.html
Log: 修复旧版控制中心无法加入内测的问题

将其加入允许安装的列表

Bug: https://pms.uniontech.com/bug-view-273975.html
Log: 修复旧版控制中心无法加入内测的问题
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在新增的常量 oldControlCenterPath 中,路径格式可能不正确,应该检查是否需要添加文件扩展名。
  • allowRemovePackageExecPaths 变量中的字符串应该使用 strings.Builder 来构建,以提高性能。
  • 检查 strv.Strv 类型是否已经包含了 oldControlCenterPath,避免重复添加。

是否建议立即修改:

@ArchieMeng
Copy link
Contributor Author

/recheck

@ArchieMeng
Copy link
Contributor Author

/retest

@ArchieMeng ArchieMeng requested a review from zsien September 19, 2024 06:55
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArchieMeng ArchieMeng merged commit 97cd1ce into linuxdeepin:master Sep 19, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants