add setting for determining the shutdown dialog default action #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An enum cannot be used here, as it should be possible to give a list of values which are tried in order until one of the actions can actually be used (all but `cancel` may not be available). The chosen default value leaves the current behaviour of defaulting to `shutdown` and apart from that orders as follows: • `cancel`, because it’s always available and safe (nothing happens). • `suspend` and `hibernate`, because they’re both safe (mostly nothing should get lost, unless one does things like downloading or burning an optical medium). `suspend` before `hibernate` as the former is faster and `hibernate` might be less likely available (it needs a sufficiently large swap active). • `restart`, because – just like `shutdown` – it may lead to loosing data. Signed-off-by: Christoph Anton Mitterer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there.
This will be needed for linuxmint/cinnamon#13108.
Please review (I'm not really a JS guy and completely new to Cinnamon's codebase).
Thanks,
Chris.