Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Setting to allow text besides icons in toolbar, closes #826 #849

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

axel358
Copy link

@axel358 axel358 commented Oct 10, 2023

No description provided.

@clefebvre
Copy link
Member

I tested this in Russian (which is notorious for having some of the longest msgstr) in 1024x768:

image

Result: It's OK. It fits.

UI-wise I don't dislike.. in fact I might even like it better. It's subjective.

My issue with it is that I don't want every little detail of every single tool to be configurable like that. If we start doing that for the position of text in the toolbar, how far can we go? I mean.. how about custom icons for the update types? re-orderable columns? Font selection for package description...

If it looks better, even if it is indeed subjective, then we should decide accordingly and go for it. If not, then we shouldn't. There's no reason to be that granular in configuration.

Also, if we adopt text beside icons, we probably need to assess where else this is done and not done and see if we change this globally or not.

I'll mark this as WIP for now.

@clefebvre clefebvre changed the title Setting to allow text besides icons in toolbar, closes #826 [WIP] Setting to allow text besides icons in toolbar, closes #826 Nov 27, 2023
@axel358
Copy link
Author

axel358 commented Nov 27, 2023

i agree that we cant we cant have a setting for everything. i went with this hack because my proposal of text besides icons for mintupdate by default was dismissed, this was just an attempt to make everyone happy :) . I would love to see this being the default with no setting required, unfortunately for small things like this sometimes is hard to get people's attention n have em give their opinions about it

@axel358
Copy link
Author

axel358 commented Nov 27, 2023

Blueman is another app that could benefit from some toolbar rework. I dont think it's worth pushing for a global setting for this since toolbars became a style class in gtk4

@axel358
Copy link
Author

axel358 commented Oct 30, 2024

Hey there. Any chances of getting this merged for the upcoming version? If not a setting making it the default look maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants