Skip to content

Conversation

tobiasdiez
Copy link

@tobiasdiez tobiasdiez commented Jun 21, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

My understanding is that the two data volumes are optional. Thus, I've moved them to opt_param_volumes.

(I guessed that this is the proper handling of optional volumes based on some other examples.)

Benefits of this PR and context:

How Has This Been Tested?

Untested.

Source / References:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.8-pkg-50571711-dev-f4a96502bbfc7f6f0e0828fca7771f36953d6bb9-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.8-pkg-50571711-dev-f4a96502bbfc7f6f0e0828fca7771f36953d6bb9-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.27.8-pkg-50571711-dev-f4a96502bbfc7f6f0e0828fca7771f36953d6bb9-pr-79
arm64v8-v1.27.8-pkg-50571711-dev-f4a96502bbfc7f6f0e0828fca7771f36953d6bb9-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.9-pkg-f1885775-dev-9660a69de443388321f3b158635f6fba71fe6a65-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.9-pkg-f1885775-dev-9660a69de443388321f3b158635f6fba71fe6a65-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.27.9-pkg-f1885775-dev-9660a69de443388321f3b158635f6fba71fe6a65-pr-79
arm64v8-v1.27.9-pkg-f1885775-dev-9660a69de443388321f3b158635f6fba71fe6a65-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.9-pkg-de7afe96-dev-353cab92e0e6290eed30ce0e61f6b691e1afefe3-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.9-pkg-de7afe96-dev-353cab92e0e6290eed30ce0e61f6b691e1afefe3-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.27.9-pkg-de7afe96-dev-353cab92e0e6290eed30ce0e61f6b691e1afefe3-pr-79
arm64v8-v1.27.9-pkg-de7afe96-dev-353cab92e0e6290eed30ce0e61f6b691e1afefe3-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.10-pkg-361b33fa-dev-7515173da9a726d7176ddbd9041971650b9641ad-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.10-pkg-361b33fa-dev-7515173da9a726d7176ddbd9041971650b9641ad-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.27.10-pkg-361b33fa-dev-7515173da9a726d7176ddbd9041971650b9641ad-pr-79
arm64v8-v1.27.10-pkg-361b33fa-dev-7515173da9a726d7176ddbd9041971650b9641ad-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.12-pkg-1244413a-dev-2c7a45192c9978d5166e16e3fbf3c088c200ca77-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.27.12-pkg-1244413a-dev-2c7a45192c9978d5166e16e3fbf3c088c200ca77-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.27.12-pkg-1244413a-dev-2c7a45192c9978d5166e16e3fbf3c088c200ca77-pr-79
arm64v8-v1.27.12-pkg-1244413a-dev-2c7a45192c9978d5166e16e3fbf3c088c200ca77-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.28.0-pkg-3f092f9e-dev-c5eee8ea15ed1977ba0ef227e9e7dc0734c57195-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.28.0-pkg-3f092f9e-dev-c5eee8ea15ed1977ba0ef227e9e7dc0734c57195-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.28.0-pkg-3f092f9e-dev-c5eee8ea15ed1977ba0ef227e9e7dc0734c57195-pr-79
arm64v8-v1.28.0-pkg-3f092f9e-dev-c5eee8ea15ed1977ba0ef227e9e7dc0734c57195-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.28.0-pkg-4eea49fc-dev-633247c41a98c98a80869b3bf7018168758c1414-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.28.0-pkg-4eea49fc-dev-633247c41a98c98a80869b3bf7018168758c1414-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.28.0-pkg-4eea49fc-dev-633247c41a98c98a80869b3bf7018168758c1414-pr-79
arm64v8-v1.28.0-pkg-4eea49fc-dev-633247c41a98c98a80869b3bf7018168758c1414-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.28.1-pkg-6c5a413b-dev-41fa58710345f32ac3cb92542c58be738079af09-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.28.1-pkg-6c5a413b-dev-41fa58710345f32ac3cb92542c58be738079af09-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.28.1-pkg-6c5a413b-dev-41fa58710345f32ac3cb92542c58be738079af09-pr-79
arm64v8-v1.28.1-pkg-6c5a413b-dev-41fa58710345f32ac3cb92542c58be738079af09-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.29.2-pkg-4ebfafd4-dev-ce1fdf0b79fb4633676e98c06e458ace51aa9b79-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.29.2-pkg-4ebfafd4-dev-ce1fdf0b79fb4633676e98c06e458ace51aa9b79-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.29.2-pkg-4ebfafd4-dev-ce1fdf0b79fb4633676e98c06e458ace51aa9b79-pr-79
arm64v8-v1.29.2-pkg-4ebfafd4-dev-ce1fdf0b79fb4633676e98c06e458ace51aa9b79-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.29.2-pkg-4ebfafd4-dev-757aa54b51740f768c9581edcfac2ba441915e8a-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.29.2-pkg-4ebfafd4-dev-757aa54b51740f768c9581edcfac2ba441915e8a-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.29.2-pkg-4ebfafd4-dev-757aa54b51740f768c9581edcfac2ba441915e8a-pr-79
arm64v8-v1.29.2-pkg-4ebfafd4-dev-757aa54b51740f768c9581edcfac2ba441915e8a-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.29.2-pkg-75e4ce30-dev-e5c5842d0b99fcde550e31fec993350e76b66fd8-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.29.2-pkg-75e4ce30-dev-e5c5842d0b99fcde550e31fec993350e76b66fd8-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.29.2-pkg-75e4ce30-dev-e5c5842d0b99fcde550e31fec993350e76b66fd8-pr-79
arm64v8-v1.29.2-pkg-75e4ce30-dev-e5c5842d0b99fcde550e31fec993350e76b66fd8-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.29.4-pkg-00a7691d-dev-4a61855d07ab2d6102bea671558077b9746f94b9-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.29.4-pkg-00a7691d-dev-4a61855d07ab2d6102bea671558077b9746f94b9-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.29.4-pkg-00a7691d-dev-4a61855d07ab2d6102bea671558077b9746f94b9-pr-79
arm64v8-v1.29.4-pkg-00a7691d-dev-4a61855d07ab2d6102bea671558077b9746f94b9-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.29.5-pkg-08603e3b-dev-b419bc11d4b8f9ca60b21cc972f245fde03b7c89-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.29.5-pkg-08603e3b-dev-b419bc11d4b8f9ca60b21cc972f245fde03b7c89-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.29.5-pkg-08603e3b-dev-b419bc11d4b8f9ca60b21cc972f245fde03b7c89-pr-79
arm64v8-v1.29.5-pkg-08603e3b-dev-b419bc11d4b8f9ca60b21cc972f245fde03b7c89-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.29.6-pkg-921e25c0-dev-270960c5b48e087a7ae84b4eed8ba83f48b2b298-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.29.6-pkg-921e25c0-dev-270960c5b48e087a7ae84b4eed8ba83f48b2b298-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.29.6-pkg-921e25c0-dev-270960c5b48e087a7ae84b4eed8ba83f48b2b298-pr-79
arm64v8-v1.29.6-pkg-921e25c0-dev-270960c5b48e087a7ae84b4eed8ba83f48b2b298-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.29.7-pkg-c5625171-dev-997476be5b4f34755fa09f137d123bb8dd9aa72e-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.29.7-pkg-c5625171-dev-997476be5b4f34755fa09f137d123bb8dd9aa72e-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.29.7-pkg-c5625171-dev-997476be5b4f34755fa09f137d123bb8dd9aa72e-pr-79
arm64v8-v1.29.7-pkg-c5625171-dev-997476be5b4f34755fa09f137d123bb8dd9aa72e-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.30.0-pkg-1a6a0c81-dev-1983cd1e34d01140485601c1bb60e19af7ad9b80-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v1.30.0-pkg-1a6a0c81-dev-1983cd1e34d01140485601c1bb60e19af7ad9b80-pr-79/shellcheck-result.xml

Tag Passed
amd64-v1.30.0-pkg-1a6a0c81-dev-1983cd1e34d01140485601c1bb60e19af7ad9b80-pr-79
arm64v8-v1.30.0-pkg-1a6a0c81-dev-1983cd1e34d01140485601c1bb60e19af7ad9b80-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v2.0.2-pkg-9ab05e4a-dev-9061163dea8bab25eb56b96061cff093799d40f1-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v2.0.2-pkg-9ab05e4a-dev-9061163dea8bab25eb56b96061cff093799d40f1-pr-79/shellcheck-result.xml

Tag Passed
amd64-v2.0.2-pkg-9ab05e4a-dev-9061163dea8bab25eb56b96061cff093799d40f1-pr-79
arm64v8-v2.0.2-pkg-9ab05e4a-dev-9061163dea8bab25eb56b96061cff093799d40f1-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v2.0.9-pkg-0c623eee-dev-1d7d60d5219dbeae8381a1344f309aaacb381d78-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v2.0.9-pkg-0c623eee-dev-1d7d60d5219dbeae8381a1344f309aaacb381d78-pr-79/shellcheck-result.xml

Tag Passed
amd64-v2.0.9-pkg-0c623eee-dev-1d7d60d5219dbeae8381a1344f309aaacb381d78-pr-79
arm64v8-v2.0.9-pkg-0c623eee-dev-1d7d60d5219dbeae8381a1344f309aaacb381d78-pr-79

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/syncthing/v2.0.10-pkg-2d984eec-dev-0213c510afee54b0c71f986c874f619347fa6932-pr-79/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v2.0.10-pkg-2d984eec-dev-0213c510afee54b0c71f986c874f619347fa6932-pr-79/shellcheck-result.xml

Tag Passed
amd64-v2.0.10-pkg-2d984eec-dev-0213c510afee54b0c71f986c874f619347fa6932-pr-79
arm64v8-v2.0.10-pkg-2d984eec-dev-0213c510afee54b0c71f986c874f619347fa6932-pr-79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants