use ES6 export, export all directives as default export, add default export test #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…export tests Updated all files (except for src/directiveLocation) to use ES6 export syntax. Changed the default export for the library to be an array of all directives to streamline usage in situations where a user wants to use all of the directives provided by the library. Added a new test to ensure the default export is an array containing only instances of GraphQLDirective. Updated README examples with new usage.
Saeris
changed the title
added 2 commits
August 24, 2018 12:09
|
conflicts? |
|
Conflicts should be resolved |
lirown
reviewed
Feb 21, 2019
| @@ -33,6 +33,7 @@ | |||
| }, | |||
| "homepage": "https://github.com/lirown/graphql-custom-directives#readme", | |||
| "dependencies": { | |||
| "lodash": "^4.17.5", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all files (except for src/directiveLocation) to use ES6 export syntax.
Changed the default export for the library to be an array of all directives to streamline usage in situations where a user wants to use all of the directives provided by the library.
Added a new test to ensure the default export is an array containing only instances of GraphQLDirective.
Updated README examples with new usage.