Improve omni-account creation and permissions #3281
Merged
+138
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds check in create_account_store to ensure an account store doesn't already exist for a given omni-account identity, preventing possible data inconsistencies or unexpected behavior. Also adds a test case to verify this validation works correctly when attempting to recreate an account store.
Adds protection against having no member with default permission in an account store. Prevents removing default permissions unless another member has them, and checks that account store has multiple members before allowing permission changes. This ensures account stores always have at least one member with admin-level access to manage the accounts.
silva-fj
changed the title
Kailai-Wang
approved these changes
Mar 8, 2025
Kailai-Wang
deleted the
p-1366-improve-omniaccount-creation-and-permissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a few improvements for the omni-account management. The most important changes include adding checks for existing account stores and ensuring permissions can only be set under specific conditions.