Fix tool use input handling #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes liushuangls#67 Address the issue of missing `input` field in `tool_use` structure by removing `omitempty` and handling empty `input`. * **message.go** - Remove `omitempty` from the `Input` field in the `MessageContentToolUse` struct. - Update the `NewMessageContentToolUse` function to handle empty `Input` by setting it to an empty JSON object if nil. * **message_stream.go** - Update the `MessagesEventContentBlockStop` case to handle empty `Input` by setting it to an empty JSON object if nil. * **message_stream_test.go** - Add test cases for tools with and without parameters to ensure proper handling of the `input` field. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/liushuangls/go-anthropic/issues/67?shareId=XXXX-XXXX-XXXX-XXXX).
liushuangls
approved these changes
Feb 21, 2025
|
Thank you! Please fix the error in actions |
WillMatthews
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Looks good overall, thank you for making that change.
Please just follow through with the rename of handlerMessagesStreamEmptyMessages to handlerMessagesStreamToolUseWithoutParameters where appropriate to make tests pass 😸
I think I would like to see an integration test too, but that's something we should add to the backlog rather than fiddle more here - I am excited to get this feature in! 🎉
| } | ||
|
|
||
| func NewMessageContentToolUse( | ||
| toolUseId, name string, | ||
| input json.RawMessage, | ||
| ) *MessageContentToolUse { | ||
| if input == nil { | ||
| input = json.RawMessage("{}") |
There was a problem hiding this comment.
nit: prefer backticks ` to a quotes " for strings in go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
Address the issue of missing
inputfield intool_usestructure by removingomitemptyand handling emptyinput.message.go
omitemptyfrom theInputfield in theMessageContentToolUsestruct.NewMessageContentToolUsefunction to handle emptyInputby setting it to an empty JSON object if nil.message_stream.go
MessagesEventContentBlockStopcase to handle emptyInputby setting it to an empty JSON object if nil.message_stream_test.go
inputfield.For more details, open the Copilot Workspace session.