Convert Python bytes and strings to Elixir binaries without copying #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bytes
are immutable andPyBytes_AsStringAndSize
returns pointer to the buffer. Similarlystr
are immutable andPyUnicode_AsUTF8AndSize
returns a pointer to cached buffer that lives as long as the object.Currently we create a new Erlang binary, which means copying the data once. This PR changes it such that we create resource around the Python objects and create a zero-copy resource binary term.