You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTCEngine gets fully town down and recreated initially when an initial connection is created and also whenever a reconnection occurs. This means that any class that has a reference to engine must be informed of this new change so that it can keep its reference to engine current.
The current means this is being done is by calling a setupEngine method on all dependents - right now, LocalParticipant and E2EEManager, plus soon OutgoingDataStreamManager. This is relatively coupled though because the room needs to call that method on each of these classes!
Potential solution
The existing approach works, but is inelegant. To attempt to solve this in a slightly more elegant way, I've added a new SupersededBy event to the RTCEngine which is fired on the old engine whenever a new engine is generated, which allows anybody who has the engine to always have the latest copy.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
Admittedly this is a little weird - EngineEventCallbacks now contains a reference to RTCEngine, so putting this expression directly within the extends creates a reference cycle that typescript doesn't seem to like. Breaking it up like this seems to solve that problem, though.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Concern
RTCEnginegets fully town down and recreated initially when an initial connection is created and also whenever a reconnection occurs. This means that any class that has a reference toenginemust be informed of this new change so that it can keep its reference toenginecurrent.The current means this is being done is by calling a
setupEnginemethod on all dependents - right now,LocalParticipantandE2EEManager, plus soonOutgoingDataStreamManager. This is relatively coupled though because the room needs to call that method on each of these classes!Potential solution
The existing approach works, but is inelegant. To attempt to solve this in a slightly more elegant way, I've added a new
SupersededByevent to theRTCEnginewhich is fired on the old engine whenever a new engine is generated, which allows anybody who has the engine to always have the latest copy.