Skip to content

Data streams #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Apr 9, 2025
Merged

Data streams #89

merged 25 commits into from
Apr 9, 2025

Conversation

ladvoc
Copy link
Contributor

@ladvoc ladvoc commented Mar 24, 2025 •
edited
Loading

Summary of changes:

  • Updates FFI to v0.12.20
  • Added support for data streams using the high-level FFI interface defined in Data streams rust-sdks#603.
  • Added code examples to README mirroring the examples from the LiveKit docs for other SDKs.

ladvoc added 22 commits March 21, 2025 12:14
@ladvoc
Add data streams proto to build script
b385ab4
@ladvoc
Generate proto
2747bff
@ladvoc
Update FFI client
8913e4c
@ladvoc
Skeleton methods
50f8c18
@ladvoc
Regenerate proto
1d2e8dc
@ladvoc
Define core classes
e3230ea
@ladvoc
Implement public methods
0b9b52b
@ladvoc
Remove unused import
ee07a24
@ladvoc
Read incremental
2936442
@ladvoc
Implement protocol conversion methods
513678e
@ladvoc
Use events for incremental reads
5e3e77e
@ladvoc
Simplify name
d1dd277
@ladvoc
Add additional documentation
43e713b
@ladvoc
Regenerate proto
4b396d4 
Revert move RPC handlers to `Room`
@ladvoc
Add missing protos
69589d9
@ladvoc
Add request types to inject method
7533284
@ladvoc
Fix ToProto methods
880a33a 
Generated proto throws an exception for null values (even though fields are optional)
@ladvoc
Make stream handlers have void return type
96ad535 
StartCoroutine must be called from custom MonoBehaviour class
@ladvoc
Add convenience methods
6045234
@ladvoc
Use yield instruction for read incremental
60f4c38
@ladvoc
Add doc comment
e68a201
@ladvoc
Add data stream code examples
bc1e77f
@ladvoc ladvoc mentioned this pull request Apr 1, 2025
Open
@ladvoc ladvoc requested a review from cloudwebrtc April 8, 2025 12:20
@ladvoc ladvoc marked this pull request as ready for review April 8, 2025 12:21
@ladvoc ladvoc requested a review from bcherry April 8, 2025 12:52
bcherry
bcherry approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ladvoc ladvoc merged commit 9a9cbf7 into main Apr 9, 2025
4 checks passed
@ladvoc ladvoc deleted the ladvoc/data-streams branch April 9, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcherry bcherry bcherry approved these changes

@cloudwebrtc cloudwebrtc Awaiting requested review from cloudwebrtc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladvoc @bcherry