Skip to content

Prevent crash when settings control is enabled in ControlBar #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Prevent crash when settings control is enabled in ControlBar #1177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/sweet-parks-shake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'@livekit/components-react': patch
---

Prevent crash when `settings` control is enabled in `ControlBar`.

Replace `useLayoutContext()` with `useMaybeLayoutContext()` in
`useSettingsToggle` to handle cases where `LayoutContext` is not provided,
preventing crashes when settings control is enabled in `ControlBar` component.
5 changes: 3 additions & 2 deletions packages/react/src/hooks/useSettingsToggle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useLayoutContext } from '../context';
import { useMaybeLayoutContext } from '../context';
import { mergeProps } from '../mergeProps';
import * as React from 'react';

Expand All @@ -15,7 +15,8 @@ export interface UseSettingsToggleProps {
* @alpha
*/
export function useSettingsToggle({ props }: UseSettingsToggleProps) {
const { dispatch, state } = useLayoutContext().widget;
const layoutContext = useMaybeLayoutContext();
const { dispatch, state } = layoutContext?.widget ?? {};
const className = 'lk-button lk-settings-toggle';

const mergedProps = React.useMemo(() => {
Expand Down