-
Notifications
You must be signed in to change notification settings - Fork 131
Update readme to include agents sdk example #1219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
size-limit report 📦
|
// Generated credentials manually and put them here | ||
// Or, generate them another way: FIXME: add docs link here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is another place the eventual TokenSource docs from here should be linked: livekit/client-sdk-js#1681
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, assuming you will address the comments, no need to wait for my second look
 | ||
|
||
## Quick Start | ||
## Agents Quick Start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea: by looking at the doc today, it seems Video Conference Quick Start is under Agent SDK Example, while I think they should be separate sections.
Does it make sense to have 1, 2 to distinguish the session that they are for different use cases like
1. Agent SDK Example
2. Video Conference Quick Start
Co-authored-by: Ben Cherry <[email protected]>
There's not a ton I added here, but I think this at least starts to point users in the direction of agents in the readme versus what was there previously.
Merging blocked on #1207 and broader docs updates (link placeholders need to be replaced with the eventual docs link urls)