Repository navigation
Composition - #107
Draft
stephen-derosa wants to merge 1 commit into
Draft
Composition#107stephen-derosa wants to merge 1 commit into
stephen-derosa wants to merge 1 commit into
Conversation
stephen-derosa
force-pushed
the
sderosa/BOT-513-composition
branch
from
September 8, 2026 20:41
b62920e to
1819468
Compare
stephen-derosa
marked this pull request as draft
September 9, 2026 19:04
stephen-derosa
commented
Sep 9, 2026
Collaborator
Author
There was a problem hiding this comment.
is this file actually needed? we should be able to simply use RCLCPP_COMPONENTS_REGISTER_NODE to expose as a component/composable. ideally we dont need this.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Composition support
Adds
ros_portal::RosPortalComponentand a composable launch file.Defers component initialization until the container owns the node.
Keeps standalone
ros_portal_nodestartup andros_threadsbehavior unchanged.Adds shared LiveKit runtime ownership, composition tests, and documentation.
Testing
colcon test-result --verbose: 403 tests, 0 failures.