Skip to content

update default workflow for depth-anything-2 #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

eliteprox
Copy link
Collaborator

@eliteprox eliteprox commented Apr 28, 2025

Updates the default comfyui workflow to use the new depth-anything-v2-large engine added in #530 and also sets the initial text prompt to blank string

@eliteprox eliteprox marked this pull request as ready for review April 28, 2025 21:58
@Copilot Copilot AI review requested due to automatic review settings April 28, 2025 21:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • runner/app/live/pipelines/comfyui_default_workflow.json: Language not supported

@eliteprox eliteprox requested a review from victorges April 28, 2025 21:58
@eliteprox
Copy link
Collaborator Author

For this change, we are waiting for prd approval. There is an FPS reduction of approx 2-3

@eliteprox eliteprox marked this pull request as draft April 28, 2025 22:03
@eliteprox eliteprox requested a review from leszko April 28, 2025 23:31
@eliteprox eliteprox changed the title Update default workflow for depth-anything-2 bump comfyui-base to v0.1.0, update default workflow for depth-anything-2 Apr 29, 2025
@eliteprox eliteprox marked this pull request as ready for review April 29, 2025 00:14
@eliteprox
Copy link
Collaborator Author

eliteprox commented Apr 29, 2025

I have reverted the base image in the PR since it includes already includes the model config for depth-anything-2-large. We still need to deploy the new depth-anything model/engine to primary staging before merging

@eliteprox eliteprox changed the title bump comfyui-base to v0.1.0, update default workflow for depth-anything-2 update default workflow for depth-anything-2 Apr 29, 2025
@eliteprox eliteprox force-pushed the jm/depth-anything-default-workflow branch from bdd9edb to 705b9af Compare May 13, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant