refactor: enhance error handling and API response management #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Jipperism
commented
Jan 10, 2026
Jipperism
commented
- Refactored multiple API routes to utilize the new error handling utilities, ensuring consistent error responses and improved maintainability.
- Improved error handling in the Claim component to log errors more effectively and provide clearer feedback on proof generation failures.
- Updated axios fetcher to throw detailed errors based on API response codes.
- Introduced a new error handling utility in the API layer to standardize error responses across various endpoints, including bad requests and internal errors.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
Closes #338 |
Jipperism
force-pushed
the
bugfix/inconsistent-api-error-handling
branch
from
6812b51 to
5930ed3
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors error handling across multiple API routes to standardize error responses and improve maintainability. It introduces a new centralized error handling utility layer and updates axios fetcher to throw structured errors based on API response codes.
Changes:
- Introduced new error handling utilities (
lib/api/errors.tsandlib/api/types/api-error.ts) that standardize error responses with consistent structure (error message, error code, optional details) - Updated 15+ API endpoints to use the new error handling utilities, replacing inconsistent error responses with standardized ones
- Enhanced client-side error handling in axios fetcher and frontend components to parse and propagate structured error messages
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/api/errors.ts | New centralized error handling utilities with functions for common HTTP error responses (400, 404, 405, 500, 502) |
| lib/api/types/api-error.ts | Type definitions for standardized API error structure with error codes |
| lib/axios.ts | Enhanced axios fetcher to extract and throw structured errors from API responses |
| utils/ipfs.ts | Added error handling for IPFS upload failures with structured error messages |
| components/Claim/index.tsx | Improved error handling for proof generation with proper error logging |
| pages/api/usage.tsx | Refactored to use new error utilities, removed nested try-catch block |
| pages/api/upload-ipfs.tsx | Updated to use new error handling utilities |
| pages/api/totalTokenSupply.tsx | Refactored with method validation and consistent error handling |
| pages/api/treasury/votes/[address]/registered.tsx | Updated to use new error utilities for validation and internal errors |
| pages/api/treasury/votes/[address]/index.tsx | Updated to use new error utilities for validation and internal errors |
| pages/api/treasury/proposal/[proposalId]/votes/[address].tsx | Updated to use new error utilities for validation and internal errors |
| pages/api/treasury/proposal/[proposalId]/state.tsx | Updated to use new error utilities for validation and internal errors |
| pages/api/score/index.tsx | Updated to use new error utilities |
| pages/api/score/[address].tsx | Updated to use new error utilities with specific external API error handling |
| pages/api/regions/index.ts | Updated to use new error utilities |
| pages/api/pipelines/index.tsx | Updated to use new error utilities |
| pages/api/pending-stake/[address].tsx | Updated to use new error utilities |
| pages/api/l1-delegator/[address].tsx | Updated to use new error utilities |
| pages/api/generateProof.tsx | Added input validation and consistent error handling |
| pages/api/ens-data/index.tsx | Updated to use new error utilities |
| pages/api/ens-data/image/[name].tsx | Updated to use new error utilities including notFound handling |
| pages/api/ens-data/[address].tsx | Updated to use new error utilities |
| pages/api/current-round.tsx | Updated to use new error utilities |
| pages/api/contracts.tsx | Updated to use new error utilities |
| pages/api/changefeed.tsx | Refactored with method validation and consistent error handling |
| pages/api/account-balance/[address].tsx | Updated to use new error utilities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ECWireless
requested changes
Jan 11, 2026
Collaborator
ECWireless
left a comment
ECWireless
left a comment
There was a problem hiding this comment.
Looks great! Though, copilot caught some super small stuff that I agree with
- Refactored multiple API routes to utilize the new error handling utilities, ensuring consistent error responses and improved maintainability. - Improved error handling in the Claim component to log errors more effectively and provide clearer feedback on proof generation failures. - Updated axios fetcher to throw detailed errors based on API response codes. - Introduced a new error handling utility in the API layer to standardize error responses across various endpoints, including bad requests and internal errors.
- Updated error handling in multiple API routes to throw detailed errors instead of returning bad requests, enhancing clarity in error reporting. - Enhanced the axios fetcher to provide more informative error messages based on API response codes. - Standardized error responses across various endpoints for better maintainability and consistency.
Jipperism
force-pushed
the
bugfix/inconsistent-api-error-handling
branch
from
648a973 to
f002b7d
Compare
Collaborator
Author
|
@ECWireless all PR feedback implemented. |
ECWireless
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.