Skip to content

Navigation patterns guide #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 65 commits into
base: main
Choose a base branch
from
Draft

Conversation

BrooklinJazz
Copy link
Contributor

@BrooklinJazz BrooklinJazz commented Jul 18, 2024

There is an issue blocking this PR.
The stylesheet doesn't recompile when changing the navigationTitle modifier.

Reproduction Steps

  • Open the livebooks/navigation_cookbook.livemd livebook. Run the Livebook.
  • Change the value of the navigation title in the code example from "OK" to "Hello" (or any other value) to reproduce the issue
  • Notice that even after 5 seconds, the stylesheet at http://localhost:4000/assets/app.swiftui.styles does not change.

BrooklinJazz and others added 30 commits April 30, 2024 13:20
Co-authored-by: Carson Katri <[email protected]>
Signed-off-by: Brooklin Myers <[email protected]>
Co-authored-by: Carson Katri <[email protected]>
Signed-off-by: Brooklin Myers <[email protected]>
Co-authored-by: Carson Katri <[email protected]>
Signed-off-by: Brooklin Myers <[email protected]>
Co-authored-by: Carson Katri <[email protected]>
Signed-off-by: Brooklin Myers <[email protected]>
Co-authored-by: Carson Katri <[email protected]>
Signed-off-by: Brooklin Myers <[email protected]>
Co-authored-by: Carson Katri <[email protected]>
Signed-off-by: Brooklin Myers <[email protected]>
Co-authored-by: Carson Katri <[email protected]>
Signed-off-by: Brooklin Myers <[email protected]>
Co-authored-by: Carson Katri <[email protected]>
Signed-off-by: Brooklin Myers <[email protected]>
@bcardarella
Copy link
Collaborator

is there anything more needed for this PR to merge?

@BrooklinJazz
Copy link
Contributor Author

BrooklinJazz commented Aug 12, 2024

is there anything more needed for this PR to merge?

@carson-katri and I are working on this together. @carson-katri I sent you a DM about one of the examples being broken.

Right now this is on the back burner for me while I focus on the workshop and more critical issues. There are several more examples I want to add to the guide. Also, theres a lot of merge conflicts I'll need to fix.

@bcardarella
Copy link
Collaborator

@BrooklinJazz why was this closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants